Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Setup prettier #11

Merged
merged 45 commits into from
Mar 17, 2019
Merged

Setup prettier #11

merged 45 commits into from
Mar 17, 2019

Conversation

GregOnNet
Copy link
Member

@GregOnNet GregOnNet commented Mar 13, 2019 •
edited
Loading

Related issue #1

@GregOnNet
prettier: install tslint-config-prettier
b8aa938
@GregOnNet
test(prettier): remove unneeded test
c33d1b8
@GregOnNet
test(pretier): use instalDependencies rule
74a92fa
@GregOnNet
test(prettier): add tslint-config-prettier to tslint configuration
9a0a43c
@GregOnNet
ref(prettier): extract tslint rule into own file
96603ef
@GregOnNet
test(prettier): handle case if extends keyword is missing in tslint.json
f4dc4df
@GregOnNet
test(prettier): skip tslint patch if json file is not present
bdbf0fb
@GregOnNet
test(prettier): improve test description
c39b7ee
@GregOnNet
test(prettoer): remove unimplemented test
3546d54
@GregOnNet
ref(prettier): extract templates in own rule
ef38c16
@GregOnNet
ref(prettier): move rules into own directory
3d6e635
@GregOnNet
ref(prettier): move tslint rule into own directory
8b4fff5
@GregOnNet
style(prettier): add missing newline
3f4b2e3
@GregOnNet
docs(prettier): add apply to the list of things that cannot be tested…
f59b9ae 
… yet
@GregOnNet
chore(packages): update jest to 24.5
8b9e968
@GregOnNet
test(prettier): check if .prettierrc is added
4b52cd8
@GregOnNet
prettier: override existing .prettierrc
c5860e4
@GregOnNet
test(prettier): warn if prettier configuration exists in package.json
ce46170
@GregOnNet
ref(prettier): reword test description
323d98e
@GregOnNet
feature(prettier): warn if competing prettier configuration is detected
200491c
@GregOnNet
ref(prettier): reword test description
e8a5c55
@GregOnNet
test(prettier/tslint): enforce single quotes
e0f74ee
@GregOnNet
test(prettier/tslint): enforce line length 80
55ce9ef
@GregOnNet
ref(prettier/tslint): extract tslint rules into own file
abed15a
@GregOnNet
test(prettier/tslint): avoid arrow parens
e87ea73
@GregOnNet
test(prettier/tslint): avoid trailing commas
d0b4285
@GregOnNet
ref(prettier): reword rule
ef77e71
@GregOnNet GregOnNet marked this pull request as ready for review March 15, 2019 16:55
@GregOnNet GregOnNet changed the title WIP Feature/prettier Setup prettier Mar 15, 2019
Markus-Ende
Markus-Ende previously approved these changes Mar 16, 2019
View reviewed changes
Copy link
Collaborator

@Markus-Ende Markus-Ende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍
Just added some hints you maybe wanna consider :-)

src/prettier/index.spec.ts Outdated Show resolved Hide resolved
src/prettier/rules/husky/apply-husky-configuration.ts Outdated Show resolved Hide resolved
src/prettier/rules/prettier/configure-prettier.spec.ts Show resolved Hide resolved
src/prettier/rules/prettier/configure-prettier.ts Outdated Show resolved Hide resolved
src/test/read-parameter-defaults.ts Outdated Show resolved Hide resolved
Markus-Ende
Markus-Ende approved these changes Mar 17, 2019
View reviewed changes
Copy link
Collaborator

@Markus-Ende Markus-Ende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GregOnNet GregOnNet merged commit c1dfa6f into master Mar 17, 2019
@GregOnNet GregOnNet mentioned this pull request Mar 17, 2019
Closed
9 tasks
@GregOnNet GregOnNet deleted the feature/prettier branch March 17, 2019 11:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Markus-Ende Markus-Ende Markus-Ende approved these changes

@FrankStrieter FrankStrieter Awaiting requested review from FrankStrieter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GregOnNet @Markus-Ende @FrankStrieter