Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows CI (AppVeyor) #144

Closed
chessai opened this issue Aug 16, 2019 · 5 comments · Fixed by #160
Closed

Add Windows CI (AppVeyor) #144

chessai opened this issue Aug 16, 2019 · 5 comments · Fixed by #160
Assignees
@vrom911
Labels
CI Hacktoberfest https://hacktoberfest.digitalocean.com/
Milestone
v0.4.0.0: Polishtown

Comments

@chessai
Copy link

chessai commented Aug 16, 2019 •
edited
Loading

Chronos already built on Mac/Linux. Now, thanks to @nprindle and @ShrykeWindgrace, it builds (and works!) on Windows as well. This isn't anything for you to fix, I'm just notifying you of the good news. Thanks!
@chshersh chshersh added the CI label Aug 16, 2019
@chshersh
Copy link
Contributor

@chessai Thanks for the notification! I think if co-log had Windows CI, such things could be noticed earlier and not leak into release. I'm renaming this issue to add Windows CI support for the future.

@chshersh chshersh changed the title Notification: Chronos now builds with Windows Add Windows CI (AppVeyor) Aug 16, 2019
@ShrykeWindgrace
Copy link

On a side note, another solution would be to use Azure CI, which has a convenient option to run tests on all three major platforms, as opposed to Appveyor which only supports windows and linux.

@chshersh
Copy link
Contributor

@ShrykeWindgrace Azure CI looks cool. But at this point, it doesn't support caching out-of-the-box. I don't have capacity at the moment to learn how to configure the cache manually with S3 buckets or something similar. However, I also heard that there is ongoing work on implementing caching on Azure CI. So once it's done, I will have a look at it. For now, we have standard AppVeyor CI config which can be copy-pasted without changes and configuring Windows CI is a 5-minute job.

@vrom911 vrom911 added the Hacktoberfest https://hacktoberfest.digitalocean.com/ label Sep 29, 2019
@vrom911
Copy link
Member

vrom911 commented Sep 29, 2019

As a good reference point for AppVeryor CI configs: https://hub.zhox.com/posts/introducing-haskell-dev/

@chshersh chshersh added this to the v0.4.0.0: Polishtown milestone Nov 8, 2019
@vrom911 vrom911 self-assigned this Dec 27, 2019
vrom911 pushed a commit that referenced this issue Dec 27, 2019
[#144] Add Windows CI (AppVeyor)
ab0aae5 
Resolves #144
@vrom911 vrom911 mentioned this issue Dec 27, 2019
Merged
chshersh added a commit that referenced this issue Dec 29, 2019
@vrom911 @chshersh
[#144] Add Windows CI (AppVeyor) (#160)
851ddcc 
* [#144] Add Windows CI (AppVeyor)

Resolves #144

* Do not build benchmarks, add badge

* Make co-log-benchmark not buildable on Windows

* Use chronos-1.1 where Windows works

* Don't build tutorials on Windows

Co-authored-by: Dmitrii Kovanikov <kovanikov@gmail.com>
@chessai
Copy link
Author

chessai commented Dec 29, 2019

Awesome work guys. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vrom911 vrom911

Labels
CI Hacktoberfest https://hacktoberfest.digitalocean.com/
Projects
None yet
Milestone
v0.4.0.0: Polishtown
Development

Successfully merging a pull request may close this issue.

[#144] Add Windows CI (AppVeyor) co-log/co-log
4 participants
@chshersh @ShrykeWindgrace @vrom911 @chessai