Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move log actions that work with String from co-log to co-log-core package #46

Closed
chshersh opened this issue Oct 2, 2018 · 2 comments
Closed
Labels
Hacktoberfest https://hacktoberfest.digitalocean.com/ log-action Everything related to LogAction data type package:co-log For: co-log package:co-log-core For: co-log-core

Comments

@chshersh
Copy link
Contributor

chshersh commented Oct 2, 2018

I would like to move the following functions to the Colog.Core.IO module:

https://github.com/kowainik/co-log/blob/695a27fe0111918d2e810c9170a2388015595fd9/co-log/src/Colog/Actions.hs#L32-L52

They use only types from the base package so they won't introduce extra dependencies. But they are still useful. And they can be used as an example of very basic and default LogAction implementations. Also, later they can be used for testing with doctest

@chshersh chshersh added package:co-log-core For: co-log-core package:co-log For: co-log log-action Everything related to LogAction data type Hacktoberfest https://hacktoberfest.digitalocean.com/ labels Oct 2, 2018
@chshersh chshersh added this to To do in #2: Hacktoberfest (October, 2018) via automation Oct 2, 2018
@sphaso
Copy link
Contributor

sphaso commented Oct 2, 2018

Hi,
I'm trying my hand at this but there's a bit of a problem with

They use only types from the base package so they won't introduce extra dependencies.

It seems that MonadIO and Handle come from Relude which is not a dependency in co-log-core. Would you suggest adding it as a dependency with a Prelude module, like done for co-log?

@chshersh
Copy link
Contributor Author

chshersh commented Oct 3, 2018

Hi, @sphaso!

It seems that MonadIO and Handle come from Relude

Relude just reexports MonadIO and Handle from the base backage. You can found them here:

  1. MonadIO
  2. Handle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest https://hacktoberfest.digitalocean.com/ log-action Everything related to LogAction data type package:co-log For: co-log package:co-log-core For: co-log-core
Projects
None yet
Development

No branches or pull requests

2 participants