Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add liftLogIO to Colog.Core.IO module: #48

Closed
chshersh opened this issue Oct 3, 2018 · 1 comment
Closed

Add liftLogIO to Colog.Core.IO module: #48

chshersh opened this issue Oct 3, 2018 · 1 comment
Labels
good first issue Good for newcomers Hacktoberfest https://hacktoberfest.digitalocean.com/ log-action Everything related to LogAction data type package:co-log-core For: co-log-core

Comments

@chshersh
Copy link
Contributor

chshersh commented Oct 3, 2018

This function:

liftLogIO :: MonadIO m => LogAction IO msg -> LogAction m msg

This might be useful.
@chshersh chshersh added good first issue Good for newcomers package:co-log-core For: co-log-core log-action Everything related to LogAction data type Hacktoberfest https://hacktoberfest.digitalocean.com/ labels Oct 3, 2018
@chshersh chshersh added this to To do in #2: Hacktoberfest (October, 2018) via automation Oct 3, 2018
@cronokirby
Copy link
Collaborator

Maybe this should go in Colog.Monad instead?

  • It avoids adding a new module
  • It avoids adding a dependency (for MonadIO) in co-log-core
  • It would go right next to the existing liftLogAction

This was referenced Oct 3, 2018
Closed
Merged
#2: Hacktoberfest (October, 2018) automation moved this from To do to Done: Issues Oct 5, 2018
chshersh pushed a commit that referenced this issue Oct 5, 2018
@cronokirby @chshersh
[#48] adds liftLogIO (#53)
027f8a5
@chshersh chshersh removed this from Done: Issues in #2: Hacktoberfest (October, 2018) Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers Hacktoberfest https://hacktoberfest.digitalocean.com/ log-action Everything related to LogAction data type package:co-log-core For: co-log-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chshersh @cronokirby