Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logShowStdout to Colog.Core.IO #63

Closed
cronokirby opened this issue Oct 13, 2018 · 1 comment
Closed

Add logShowStdout to Colog.Core.IO #63

cronokirby opened this issue Oct 13, 2018 · 1 comment
Labels
Hacktoberfest https://hacktoberfest.digitalocean.com/ log-action Everything related to LogAction data type package:co-log-core For: co-log-core

Comments

@cronokirby
Copy link
Collaborator

This came up in #61 while resolving #58:

In the documentation examples it was often needed to log a value implementing Show, e.g. Int, (), etc.
I think this would a useful function to add to Colog.Core.IO.
logShowStdout is just a first idea of a name; it matches logStringStdout, but maybe we want logPrint
or something else instead.
@chshersh chshersh added package:co-log-core For: co-log-core log-action Everything related to LogAction data type Hacktoberfest https://hacktoberfest.digitalocean.com/ labels Oct 13, 2018
@chshersh chshersh added this to To do in #2: Hacktoberfest (October, 2018) via automation Oct 13, 2018
@chshersh
Copy link
Contributor

@cronokirby I'm actually okay with logPrint because by default print outputs to stdout so logPrint is short and self-explanatory name. If desired, we can add logPrintStderr though it kinda against convention... I propose to gather more feedback under this issue before implementing.

gahag added a commit to gahag/co-log that referenced this issue Oct 21, 2018
@gahag
[co-log#63] Add logPrint and logPrintStderr to Colog.Core.IO.
8e081cd 
Added the suggested `logPrint` and `logPrintStderr`.
Updated the benchmarks to test `logPrint`.
Updated example to use the new functions.
@gahag gahag mentioned this issue Oct 21, 2018
Merged
gahag added a commit to gahag/co-log that referenced this issue Oct 23, 2018
@gahag
[co-log#63] Add logPrint and logPrintStderr to Colog.Core.IO
b7c7c16 
Updated changelog.
chshersh pushed a commit that referenced this issue Oct 24, 2018
@gahag @chshersh
[#63] Add logPrint and logPrintStderr to Colog.Core.IO. (#66)
41cc915 
* [#63] Add `logPrint` and `logPrintStderr` to Colog.Core.IO.

Added the suggested `logPrint` and `logPrintStderr`.
Updated the benchmarks to test `logPrint`.
Updated example to use the new functions.

* [#63] Add `logPrint` and `logPrintStderr` to Colog.Core.IO

Updated changelog.
#2: Hacktoberfest (October, 2018) automation moved this from To do to Done: Issues Oct 24, 2018
@chshersh chshersh removed this from Done: Issues in #2: Hacktoberfest (October, 2018) Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest https://hacktoberfest.digitalocean.com/ log-action Everything related to LogAction data type package:co-log-core For: co-log-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chshersh @cronokirby