Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using faster time formatting #77

Closed
chshersh opened this issue Nov 14, 2018 · 1 comment
Closed

Consider using faster time formatting #77

chshersh opened this issue Nov 14, 2018 · 1 comment
Labels
benchmarks good first issue Good for newcomers help wanted Extra attention is needed

Comments

@chshersh
Copy link
Contributor

There're benchmarks in chronos library regarding time pretty printing:

katip logging library also has fast implementation of time formatting:

@chshersh chshersh added this to To do in #3: Hero Academia (November, 2018) via automation Nov 14, 2018
@chshersh chshersh added help wanted Extra attention is needed good first issue Good for newcomers labels Nov 17, 2018
@chshersh
Copy link
Contributor Author

chshersh commented Jan 8, 2019

You can see benchmarks results in chronos library:

It seems that chronos is the fastest library. I also launched benchmarks for katip locally and looks like katip has approximately the same performance as chronos. So if we want fastest time formatting, it's easier to depend on chronos and use time formatting from this library.

chshersh pushed a commit that referenced this issue Jan 15, 2019
* Add chronos dependency and fix format

* Add chronos datetime formatter

* Fix build

* Review

* Lazy text proposal

* Bump up resolver version and change co-log version from 0.2.0 to 0.3.0

* Fix issues from review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant