Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHC 9 support #223

Merged
merged 8 commits into from
Aug 21, 2021
Merged

GHC 9 support #223

merged 8 commits into from
Aug 21, 2021

Conversation

sorki
Copy link
Contributor

@sorki sorki commented Aug 14, 2021

Relaxes base bounds, bumps typerep-map and polysemy.

Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sorki ,

Thanks a lot for this update! Looks nice!
Could you please also add 9.0 into the GitHub Actions file, so we could have a check on CI that everything is still good?

@sorki
Copy link
Contributor Author

sorki commented Aug 18, 2021

Sure, added! I think it's going to get cancelled due to some unrelated fail in older one(s) but lets see.

@sorki
Copy link
Contributor Author

sorki commented Aug 18, 2021

All green now.

Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks neat 🙂

Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vrom911 vrom911 merged commit 72fbe39 into co-log:main Aug 21, 2021
@alaendle
Copy link
Member

With support for ghc 9, isn't it time to release new versions? I know it's cheeky to ask, but it would make usage of these great libraries much easier 😇

@chshersh
Copy link
Contributor

@alaendle The latest version of GHC 9 still has serious bugs so I wouldn't recommend using it in production 🙂

We work on co-log in our free time, so the new release depends on our availability. But we're currently working on moving co-log to a new home and preparing new versions for the release, so you can expect a new release relatively soon 👍🏻

Thus being said, we just released co-log-core-0.3.0.0 with GHC 9 support:

@alaendle
Copy link
Member

@chshersh - Just a small addendum to clarify the intention of my request. I'm not particularly interested in support for GHC 9, but the strict version bounds on the latest released co-log-polysemy package (polysemy (>=1.2.0.0 && <1.4)) no longer match stack LTS 18.14 (https://www.stackage.org/lts-18.14/package/polysemy-1.5.0.0). The great thing is that everything is already available on github - so until a new release is published I just can reference the git repository in my extra-deps stack.yaml section 👍

@chshersh
Copy link
Contributor

chshersh commented Nov 4, 2021

@alaendle FYI, co-log-polysemy-0.0.1.3 has been released to Hackage with GHC 9.0 support.

@alaendle
Copy link
Member

alaendle commented Nov 8, 2021

@chshersh Many thanks for the hint, unfortunately my project not only depends in co-log-polysemy, but only on co-log - so since their latest releases on hackage differ in the version dependency on co-log-core ((>=0.3.0.0 && <0.4) vs. (>=0.2.1.0 && <0.3)) I'm still using the git repository

extra-deps:
- git: https://github.com/co-log/co-log.git
  commit: 72fbe394b437c698d574cd7604ad3f7f807383e0
  subdirs:
    - co-log
    - co-log-core
    - co-log-polysemy

for now. This is only for explanation and if someone experiences a similar problem and in absolute no way criticism! I really appreciate your work and the design of the co-log library in particular 👍 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants