Support custom formatting - especially allow easy TZ support 😄 #226
Conversation
|
Oh dear, the CI has definitely not been running for too long 😢😉 |
|
@alaendle I'll update CI in a separate PR as well where I'll move |
|
@chshersh One of my weaknesses, I'm impatient 😉. Could you please once more approve the start of the workflow? My hope is that the latest ubuntu image contains the missing lib (since the ci from co-log-core seems to work). I just see it as an intellectual challenge to get this up and running 🤦♂️. And even with https://github.com/nektos/act it's hard to foresee how the actual github runner will behave. |
|
@alaendle I gave Write access to this repository. I believe, if you open PRs next time, you won't need other maintainers' approval to run CI 🙂 |
|
Wow thanks! CI build is running, so maybe it's now time for feedback for the change and concentrate on the improvement of the intended change. Thanks again! |
|
Happy New Year @chshersh, I don't want to push, but is there any way to get ahead? Any obstacles that I could resolve? |
| >>> showThreadId <$> Control.Concurrent.myThreadId | ||
| "[ThreadId 4898] " |
There was a problem hiding this comment.
I'm afraid this test won't work because ThreadId is non-deterministic and could be different each time 😞
But I wonder how tests are passing here on multiple CIs 🤔
There was a problem hiding this comment.
Seems co-log doesn't run doctest - I'll take a look what changes are required to add it.
Arises from #217. As a first commit, just the basic changes to reduce code duplication.