Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#189] Add OSX check on CI #234

Merged
merged 4 commits into from
Feb 21, 2022
Merged

[#189] Add OSX check on CI #234

merged 4 commits into from
Feb 21, 2022

Conversation

chshersh
Copy link
Contributor

Resolves #189

@chshersh chshersh self-assigned this Feb 15, 2022
@chshersh chshersh added the CI label Feb 15, 2022
vrom911
vrom911 approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍🏼

@chshersh chshersh force-pushed the chshersh/189-Add-OSX-check-on-CI branch from 7732057 to e1611fd Compare February 21, 2022 09:44
@chshersh
Copy link
Contributor Author

Just added chronos as a GitHub dependency from my fork to see how well CI works. Should be removed once chronos is released to Hackage 💎

@vrom911
Copy link
Member

vrom911 commented Feb 21, 2022

Nice! Should we wait or merge as it is now?

@chshersh
Copy link
Contributor Author

@vrom911 We can merge now (as the PR fixes CI substantially) and open a separate PR for removing GitHub dependency after the new chronos release:

@vrom911 vrom911 merged commit a53122d into main Feb 21, 2022
@vrom911 vrom911 deleted the chshersh/189-Add-OSX-check-on-CI branch February 21, 2022 12:42
@NicolasT
Copy link
Contributor

NicolasT commented Sep 9, 2022

Looks like https://github.com/chshersh/chronos no longer exists (or not publicly, at least), and ref d16494c1df61023dab63d41d276c55f233ef887e doesn't exist in https://github.com/andrewthad/chronos, hence given the cabal.project file in this repository a simple cabal build fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrom911 vrom911 vrom911 approved these changes

Assignees

@chshersh chshersh

Labels
CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add OSX check on CI
3 participants
@chshersh @vrom911 @NicolasT