Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorials: add demo for LoggerT and SimpleMsg, #84 #256

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

xieyuschen
Copy link
Member

I'm going to add all tutorials under #84.

As I'm not a senior person to Haskell, please correct me if I make any mistake.

Regard

@xieyuschen xieyuschen force-pushed the tutorials/loggert-simple-msg branch from 22404f2 to 5297a11 Compare June 23, 2023 10:49
@xieyuschen xieyuschen force-pushed the tutorials/loggert-simple-msg branch from b2baac0 to 08cdd0c Compare June 26, 2023 09:25
@xieyuschen xieyuschen marked this pull request as ready for review June 26, 2023 09:27
@xieyuschen xieyuschen requested a review from vrom911 as a code owner June 26, 2023 09:27
@xieyuschen
Copy link
Member Author

Hi @vrom911 , could you kindly to review the PR about tutorials?

@alaendle
Copy link
Member

alaendle commented Jul 2, 2023

Without having a detailed look, anything is better than nothing; so please merge directly - if there is still a need for improvement, this can also be done later.

@xieyuschen
Copy link
Member Author

Hi @alaendle @vrom911 , could you kindly help to review this PR? If there are some places to be fixed, I'm glad to improve it in the PR also.

@alaendle
Copy link
Member

@xieyuschen (fyi @vrom911) - Unfortunately there is nothing I can do; I have not the necessary rights/permissions to push things forward (guess I have to be added to the code owner files to be able to do reviews/merges).

@vrom911
Copy link
Member

vrom911 commented Aug 16, 2023

Appologies!
@alaendle I remove the code owners permission, you could add yourself later as well, it would be great too!

@xieyuschen thanks a lot for your contributions! ❤️

@alaendle alaendle self-requested a review August 16, 2023 18:18
@alaendle
Copy link
Member

@vrom911 Thank you for your trust 😄 Still I see...
grafik

@vrom911
Copy link
Member

vrom911 commented Aug 16, 2023

Sorry, @alaendle , still figuring it out! Can you try now? I gave you admin permissions now :)

@alaendle
Copy link
Member

Thanks - now I would be able to merge - but this is up to your review:
grafik

@alaendle
Copy link
Member

@vrom911 - Btw, could you also give me these permissions on the other repos of the org? 😉

@vrom911
Copy link
Member

vrom911 commented Aug 16, 2023

@alaendle Should have all the accesses and righys to all repos in the org, thanks a lot for helping with this ❤️

@alaendle
Copy link
Member

@vrom911 Many thanks! 👏

@xieyuschen
Copy link
Member Author

Thanks - now I would be able to merge - but this is up to your review: grafik

oops, the PR is pending for your @vrom911 review.

@vrom911
Copy link
Member

vrom911 commented Aug 17, 2023

@alaendle I think one review is fine for the PR, so feel free to merge PRs that you approved even if I didn't get to review that yet (especially if it takes too much time) 👌🏼

@vrom911 vrom911 merged commit 7e20b45 into co-log:main Aug 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants