-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tutorials: add demo for LoggerT and SimpleMsg, #84 #256
Conversation
22404f2
to
5297a11
Compare
b2baac0
to
08cdd0c
Compare
Hi @vrom911 , could you kindly to review the PR about tutorials? |
Without having a detailed look, anything is better than nothing; so please merge directly - if there is still a need for improvement, this can also be done later. |
@xieyuschen (fyi @vrom911) - Unfortunately there is nothing I can do; I have not the necessary rights/permissions to push things forward (guess I have to be added to the code owner files to be able to do reviews/merges). |
Appologies! @xieyuschen thanks a lot for your contributions! ❤️ |
@vrom911 Thank you for your trust 😄 Still I see... |
Sorry, @alaendle , still figuring it out! Can you try now? I gave you admin permissions now :) |
@vrom911 - Btw, could you also give me these permissions on the other repos of the org? 😉 |
@alaendle Should have all the accesses and righys to all repos in the org, thanks a lot for helping with this ❤️ |
@vrom911 Many thanks! 👏 |
oops, the PR is pending for your @vrom911 review. |
@alaendle I think one review is fine for the PR, so feel free to merge PRs that you approved even if I didn't get to review that yet (especially if it takes too much time) 👌🏼 |
I'm going to add all tutorials under #84.
As I'm not a senior person to Haskell, please correct me if I make any mistake.
Regard