Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorials: add a tutorial for loggert and message #261

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

xieyuschen
Copy link
Member

Add a tutorial as proposed #84 for message and loggert.
This PR includes:

  • Same example but with LoggerT monad and rich message
  • Basic example with LoggerT but not printing threadId

Regards

Copy link
Member

@vrom911 vrom911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added few small comments 🙂

tutorials/3-loggert-with-message/README.md Outdated Show resolved Hide resolved
tutorials/3-loggert-with-message/README.md Outdated Show resolved Hide resolved
tutorials/3-loggert-with-message/README.md Outdated Show resolved Hide resolved
tutorials/3-loggert-with-message/README.md Outdated Show resolved Hide resolved
tutorials/3-loggert-with-message/README.md Outdated Show resolved Hide resolved
@xieyuschen xieyuschen force-pushed the tutorials/loggert-with-message branch 4 times, most recently from a5c4f57 to a00c332 Compare September 4, 2023 06:27
Co-authored-by: Veronika Romashkina <vrom911@gmail.com>
@xieyuschen
Copy link
Member Author

Thanks! Added few small comments 🙂

hi @vrom911 thank you for reviewing! I applied your suggestions and squash them. If you have any concerns about the PR, kindly let me know:)

Copy link
Member

@alaendle alaendle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your effort; to be honest I haven't looked in details yet - but what I've seen on a quick way looks good 👍

@alaendle alaendle merged commit d883f69 into co-log:main Sep 8, 2023
6 checks passed
@alaendle
Copy link
Member

alaendle commented Sep 8, 2023

@xieyuschen Many thanks; do you have interest to be added as a collaborator - this would give you at least some more access rights ;-) If not that's also fine; we are happy about any contribution from your side.

@xieyuschen
Copy link
Member Author

xieyuschen commented Sep 8, 2023

@xieyuschen Many thanks; do you have interest to be added as a collaborator - this would give you at least some more access rights ;-) If not that's also fine; we are happy about any contribution from your side.

@alaendle Sure, it's an honor to be a collaborator:)

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants