Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run doctests for co-log-core #54

Merged
merged 5 commits into from
Oct 6, 2018
Merged

Run doctests for co-log-core #54

merged 5 commits into from
Oct 6, 2018

Conversation

tfausak
Copy link
Contributor

@tfausak tfausak commented Oct 5, 2018

Fixes #47.

@chshersh chshersh added doc tests Hacktoberfest https://hacktoberfest.digitalocean.com/ labels Oct 5, 2018
@chshersh chshersh added this to In progress in #2: Hacktoberfest (October, 2018) via automation Oct 5, 2018
chshersh
chshersh reviewed Oct 5, 2018
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tfausak Thanks for your contribution! Need to check why the CI is failing 🤔

chshersh
chshersh reviewed Oct 6, 2018
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, some dependencies are conflicting. The following should fix the CI:

Relax time constraints in co-log package to the following:

                     , time >= 1.8 && < 1.10

It's here:

https://github.com/kowainik/co-log/blob/027f8a5acad5c90b30fcb22e08a3bf93379e5db1/co-log/co-log.cabal#L46

co-log-core/src/Colog/Core/Action.hs Outdated
@@ -1,4 +1,5 @@
{-# LANGUAGE CPP #-}
{-# LANGUAGE InstanceSigs #-}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This extension is enabled by default for whole project. It's very useful! So I think that instead of adding it to every manually, you can just write:

main = Doctest.doctest [ "-XInstanceSigs", "src" ]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good call! I didn't realize you could pass GHC options to doctest.

@chshersh chshersh mentioned this pull request Oct 6, 2018
Merged
#2: Hacktoberfest (October, 2018) automation moved this from In progress to Reviewer approved Oct 6, 2018
chshersh
chshersh approved these changes Oct 6, 2018
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the contribution! ❤️

@chshersh chshersh merged commit 028152b into co-log:master Oct 6, 2018
#2: Hacktoberfest (October, 2018) automation moved this from Reviewer approved to Done: PR's Oct 6, 2018
@tfausak tfausak deleted the gh-47-doctest branch October 6, 2018 15:34
@tfausak
Copy link
Contributor Author

tfausak commented Oct 6, 2018

💞 Thanks!

@chshersh chshersh removed this from Done: PR's in #2: Hacktoberfest (October, 2018) Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh chshersh approved these changes

@vrom911 vrom911 Awaiting requested review from vrom911

Assignees

@tfausak tfausak

Labels
doc Hacktoberfest https://hacktoberfest.digitalocean.com/ tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tfausak @chshersh