bears: Fix ASCIINEMA_URLS #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove arguments from URLs so embedding in websites works properly. Closes #662
|
ack 73374c3 |
|
@rultor merge |
|
@mr-karan did you ack this by yourself? |
|
@sils1297 Uhm sorry, I thought it was a pretty small change. |
|
Hey, self acknowledgment is only allowed when absolutely necessary. Say master branch is failing a build and a revert needs to get in to fix it. The size of a change doesn't really matter. The commit looks good though, message could have been better. |
|
Ah I didn't really know about this. Sorry, will keep it in mind from now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove arguments from URLs so
embedding in websites works properly.
Closes #662