-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coala-json should give relpaths of files #1593
Comments
commit was reverted @tushar-rishav you're still assigned |
Why was the commit reverted ? Wouldn't it be possible to track whether the user gave a relative path for the file glob and decide on abs or rel based on that ? |
it broke because the file_dict still used absolute paths so coala couldn't 2016-02-22 13:03 GMT+01:00 AbdealiJK notifications@github.com:
|
we already use relative paths for the output of filenames in 2016-02-22 13:05 GMT+01:00 Lasse Schuirmann lasse.schuirmann@gmail.com:
|
Ah, ^ @sils1297 I disliked the ConsoleInteraction using relpaths then - as it gave me the Why exactly does |
so if you do the json dump the html/js page uses paths to get file 2016-02-22 13:09 GMT+01:00 AbdealiJK notifications@github.com:
|
Maybe have a On Mon, Feb 22, 2016 at 5:43 PM, Lasse Schuirmann notifications@github.com
|
Yes. It's possible to convert abspath in json_dump file from
|
@tushar-rishav it's quite a bit simpler - We just add an |
Makes sense. Let me try.
|
IMO we should output relative paths in all scenarios. (This is needed for coala-html to work based on coala-json.)
The text was updated successfully, but these errors were encountered: