ExternalBearWrap: Change JSON spec #2407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redridge
force-pushed
the
red/EBW-jsonspec
branch
from
a2d2a6d
to
f05de48
Compare
Redridge
force-pushed
the
red/EBW-jsonspec
branch
from
f05de48
to
1778263
Compare
|
This is a test run to investigate the failures on the CI |
Redridge
force-pushed
the
red/EBW-jsonspec
branch
4 times, most recently
from
28142b4
to
46cb551
Compare
| origin=self, | ||
| for result in output['results']: | ||
| affected_code = (SourceRange.from_values( | ||
| code_range['file'], |
Redridge
force-pushed
the
red/EBW-jsonspec
branch
3 times, most recently
from
d0d451a
to
5217af9
Compare
| code_range['start'].get('column'), | ||
| code_range.get('end', {}).get('line'), | ||
| code_range.get('end', {}).get('column')) | ||
| for code_range in result['affected_code']) |
There was a problem hiding this comment.
this line should be indented 6 spaces further, the ones above 10 spaces further
|
ack 5217af9 - so much better :) |
Redridge
force-pushed
the
red/EBW-jsonspec
branch
from
5217af9
to
cdb1553
Compare
Redridge
force-pushed
the
red/EBW-jsonspec
branch
from
cdb1553
to
6201b31
Compare
Redridge
force-pushed
the
red/EBW-jsonspec
branch
from
6201b31
to
f9dfb4c
Compare
|
ack 535bf93 |
|
ack f9dfb4c |
|
@rultor merge |
sils
added
process/approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2406
Fixes #2368