cEP-0024.md: GitMate Plugins #142

Vamshi99 · 2018-05-10T15:41:04Z

Closes #141

gitmate-bot · 2018-05-10T15:41:23Z

cEP-0024.md

@@ -0,0 +1,84 @@
+Implement GitMate automations and plugins for coala


The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpmw__hwag/cEP-0024.md +++ b/tmp/tmpmw__hwag/cEP-0024.md @@ -1,17 +1,15 @@ -Implement GitMate automations and plugins for coala -=================================================== +# Implement GitMate automations and plugins for coala -|Metadata| | -|--------|---------------------------------------------------| -|cEP |24 | -|Version |1.0 | -|Title |Implement Gitmate automations and plugins for coala| -|Authors |Vamshi Krishna Bommerla <bommvams72@gmail.com> | -|Status |Proposed | -|Type |Process | +| Metadata | | +| -------- | ----------------------------------------------------- | +| cEP | 24 | +| Version | 1.0 | +| Title | Implement Gitmate automations and plugins for coala | +| Authors | Vamshi Krishna Bommerla <mailto:bommvams72@gmail.com> | +| Status | Proposed | +| Type | Process | -Abstract --------- +## Abstract This cEP describes the details of the process of creating new automations and plugins in GitMate which helps coala development workflow, as a part of the

gitmate-bot · 2018-05-10T15:46:56Z

cEP-0024.md

@@ -0,0 +1,84 @@
+Implement GitMate automations and plugins for coala


The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpmw__hwag/cEP-0024.md +++ b/tmp/tmpmw__hwag/cEP-0024.md @@ -1,17 +1,15 @@ -Implement GitMate automations and plugins for coala -=================================================== +# Implement GitMate automations and plugins for coala -|Metadata| | -|--------|---------------------------------------------------| -|cEP |24 | -|Version |1.0 | -|Title |Implement Gitmate automations and plugins for coala| -|Authors |Vamshi Krishna Bommerla <bommvams72@gmail.com> | -|Status |Proposed | -|Type |Process | +| Metadata | | +| -------- | ----------------------------------------------------- | +| cEP | 24 | +| Version | 1.0 | +| Title | Implement Gitmate automations and plugins for coala | +| Authors | Vamshi Krishna Bommerla <mailto:bommvams72@gmail.com> | +| Status | Proposed | +| Type | Process | -Abstract --------- +## Abstract This cEP describes the details of the process of creating new automations and plugins in GitMate which helps coala development workflow, as a part of the

sks444 · 2018-05-10T18:31:42Z

cEP-0024.md

@@ -0,0 +1,82 @@
+#Implement GitMate automations and plugins for coala


space after #

sks444 · 2018-05-10T18:32:18Z

cEP-0024.md

+| Status   | Proposed                                              |
+| Type     | Process                                               |
+
+##Abstract


same as above.

sks444 · 2018-05-10T18:36:49Z

cEP-0024.md

+
+### Auto-assign issue based on commit mention
+
+When a commit mentions(fixes,closes) an issue, auto assign unassigned issues.


space after ,

sks444 · 2018-05-10T18:37:38Z

cEP-0024.md

+### Auto-reject PR opened on master of forks
+
+Normally, we should make changes in different branch from master of forks, and
+submit a PR. But, sometimes we receive PR’s from master of forks. To solve this


PR's --> PRs ?

sks444 · 2018-05-10T18:44:03Z

cEP-0024.md

+
+Our members often confuse when we should use `Fixes` or `Closes` on a commit.
+So, GitMate should automatically check every commit for issues which is being
+Fixed or Closed, if those issues have bug label, fixes should be used, and


fixes should be used --> Fixes should be used

sks444 · 2018-05-10T18:46:15Z

cEP-0024.md

+
+Our members often confuse when we should use `Fixes` or `Closes` on a commit.
+So, GitMate should automatically check every commit for issues which is being
+Fixed or Closed, if those issues have bug label, fixes should be used, and


issues have bug label --> issues have a label bug?

Will the list of labels be configuration?

If it is a specific label, what happens if the repo doesnt have that label? Will GitMate create the label? what color will it be?

sks444 · 2018-05-10T18:52:09Z

cEP-0024.md

+
+Sometimes, there will be members in the organisation, misusing the rights,
+violating the code of conduct, disturbing our workflow. It will definitely take
+some time to fix that security issue, bearing that user, until then will be a


until then there will be a..?

sks444 · 2018-05-10T18:57:24Z

cEP-0024.md

+
+### Assign Plugin
+
+Assign issue when a user comments on an issue requesting for an assignemnet


assignemnet --> assignment

What will be the syntax for the user requesting assignment?

What will be the rules in place before the user is assigned.
We have lots of rules in corobo, including the not implemented 'GCI' problem where a specific subset of issues are reserved for a subset of users, and the org is expected to let only the student finish the task if they have claimed it in GCI.

jayvdb · 2018-05-11T04:26:10Z

cEP-0024.md

+
+## Introduction
+
+GitMate.io is an automation tool for developers. While it works well, there are


link to https://gitmate.io ?

jayvdb · 2018-05-11T05:13:09Z

cEP-0024.md

+
+### Auto-assign issue based on commit mention
+
+When a commit mentions(fixes,closes) an issue, auto assign unassigned issues.


will it provide a comment on the issue that coala can configure to suit our needs?

and what happens if they are not an org member, and cant be assigned?

a comment pinging maintainers?

a gitmate managed queue for maintainers to check?

Nothing about this has been added.

@jayvdb
Yes, a configurable comment on the issue when user is assigned.

If they are not in the org, they will be informed to get invited.

I am thinking of a directly assigning the user to the issue.

jayvdb · 2018-05-11T05:25:05Z

cEP-0024.md

+Normally, we should make changes in different branch from master of forks, and
+submit a PR. But, sometimes we receive PR’s from master of forks. To solve this
+problem, we need a mechanism by which gitmate automatically rejects those PR’s,
+and inform the PR author to work on a different branch.


and if they repeat the problem? ... ;-)

We are informing them to work on different branch and open the PR, however if they are repeating the same, we can't do anything else.

jayvdb · 2018-05-11T05:26:55Z

cEP-0024.md

+
+### Auto-mark PR with necessary labels as per the reviews done
+
+When a reviewer reviews a PR and either he approves changes or request changes


'approves'/'requests changes' means ack/nack and/or GitHub review approvals/review changes requested & GitLab MR approvals / comments ?

GitHub review approvals/review changes requested & GitLab MR approvals / comments

jayvdb · 2018-05-11T05:28:25Z

cEP-0024.md

+
+Our members often confuse when we should use `Fixes` or `Closes` on a commit.
+So, GitMate should automatically check every commit for issues which is being
+Fixed or Closed, if those issues have bug label, fixes should be used, and


Will the list of labels be configuration?

If it is a specific label, what happens if the repo doesnt have that label? Will GitMate create the label? what color will it be?

jayvdb · 2018-05-11T05:30:23Z

cEP-0024.md

+violating the code of conduct, disturbing our workflow. It will definitely take
+some time to fix that security issue, bearing that user, until then will be a
+lot of pain. So, a plugin to ban a user from using GitMate further and removing
+his rights at that very moment will be helpful. Ban user plugin will be created


how will the plugin work?

how do we ban the user?

in gitmate.io UI , or on GitHub/GitLab comments?

or we remove them from GitHub/GitHub org members, and GitMate respects the GitHub/GitHub org members?

jayvdb · 2018-05-11T05:32:36Z

cEP-0024.md

+
+### Assign Plugin
+
+Assign issue when a user comments on an issue requesting for an assignemnet


What will be the syntax for the user requesting assignment?

What will be the rules in place before the user is assigned.
We have lots of rules in corobo, including the not implemented 'GCI' problem where a specific subset of issues are reserved for a subset of users, and the org is expected to let only the student finish the task if they have claimed it in GCI.

jayvdb · 2018-05-11T05:33:25Z

cEP-0024.md

+
+Check for merge conflicts and give link to documentation on how to fix it.
+
+## Mockups


oh, the mockups are here. I think it is more useful to have them in the relevant sections.

gitmate-bot · 2018-05-12T13:47:39Z

cEP-0024.md

+Assign issue when a user comments on an issue requesting for an `assignment`
+to that issue. Will support settings for each team like limit team to work on
+issues with specific set of labels, limit number of issues of specified label,
+a team member can work on. 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpzfajtu_d/cEP-0024.md +++ b/tmp/tmpzfajtu_d/cEP-0024.md @@ -66,7 +66,7 @@ Assign issue when a user comments on an issue requesting for an `assignment` to that issue. Will support settings for each team like limit team to work on issues with specific set of labels, limit number of issues of specified label, -a team member can work on. +a team member can work on.

Settings:

gitmate-bot · 2018-05-12T13:47:40Z

cEP-0024.md

+
+> @gitmate-bot assign
+
+  @user, you have been assigned


The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpzfajtu_d/cEP-0024.md +++ b/tmp/tmpzfajtu_d/cEP-0024.md @@ -81,8 +81,8 @@ > @gitmate-bot assign @user, you have been assigned +

Auto-review merge conflicts

Check for merge conflicts and give link to documentation on how to fix it.

gitmate-bot · 2018-05-12T13:47:41Z

cEP-0024.md

+
+### Auto-review merge conflicts
+
+Check for merge conflicts and give link to documentation on how to fix it.


The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpzfajtu_d/cEP-0024.md +++ b/tmp/tmpzfajtu_d/cEP-0024.md @@ -86,3 +86,4 @@ ### Auto-review merge conflicts Check for merge conflicts and give link to documentation on how to fix it. +```

gitmate-bot · 2018-05-12T13:52:36Z

cEP-0024.md

+Assign issue when a user comments on an issue requesting for an `assignment`
+to that issue. Will support settings for each team like limit team to work on
+issues with specific set of labels, limit number of issues of specified label,
+a team member can work on. 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpzfajtu_d/cEP-0024.md +++ b/tmp/tmpzfajtu_d/cEP-0024.md @@ -66,7 +66,7 @@ Assign issue when a user comments on an issue requesting for an `assignment` to that issue. Will support settings for each team like limit team to work on issues with specific set of labels, limit number of issues of specified label, -a team member can work on. +a team member can work on.

Settings:

gitmate-bot · 2018-05-12T13:52:36Z

cEP-0024.md

+
+> @gitmate-bot assign
+
+  @user, you have been assigned


The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpzfajtu_d/cEP-0024.md +++ b/tmp/tmpzfajtu_d/cEP-0024.md @@ -81,8 +81,8 @@ > @gitmate-bot assign @user, you have been assigned +

Auto-review merge conflicts

Check for merge conflicts and give link to documentation on how to fix it.

gitmate-bot · 2018-05-12T13:52:37Z

cEP-0024.md

+
+### Auto-review merge conflicts
+
+Check for merge conflicts and give link to documentation on how to fix it.


The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpzfajtu_d/cEP-0024.md +++ b/tmp/tmpzfajtu_d/cEP-0024.md @@ -86,3 +86,4 @@ ### Auto-review merge conflicts Check for merge conflicts and give link to documentation on how to fix it. +```

gitmate-bot · 2018-05-12T13:55:43Z

cEP-0024.md

+Assign issue when a user comments on an issue requesting for an `assignment`
+to that issue. Will support settings for each team like limit team to work on
+issues with specific set of labels, limit number of issues of specified label,
+a team member can work on. 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpzfajtu_d/cEP-0024.md +++ b/tmp/tmpzfajtu_d/cEP-0024.md @@ -66,7 +66,7 @@ Assign issue when a user comments on an issue requesting for an `assignment` to that issue. Will support settings for each team like limit team to work on issues with specific set of labels, limit number of issues of specified label, -a team member can work on. +a team member can work on.

Settings:

gitmate-bot · 2018-05-12T13:55:43Z

cEP-0024.md

+
+> @gitmate-bot assign
+
+  @user, you have been assigned


The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpzfajtu_d/cEP-0024.md +++ b/tmp/tmpzfajtu_d/cEP-0024.md @@ -81,8 +81,8 @@ > @gitmate-bot assign @user, you have been assigned +

Auto-review merge conflicts

Check for merge conflicts and give link to documentation on how to fix it.

gitmate-bot · 2018-05-12T13:55:44Z

cEP-0024.md

+
+### Auto-review merge conflicts
+
+Check for merge conflicts and give link to documentation on how to fix it.


The text does not comply to the set style.

Origin: MarkdownBear, Section: markdown.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpzfajtu_d/cEP-0024.md +++ b/tmp/tmpzfajtu_d/cEP-0024.md @@ -86,3 +86,4 @@ ### Auto-review merge conflicts Check for merge conflicts and give link to documentation on how to fix it. +```

sils · 2018-05-14T14:15:50Z

cEP-0024.md

+
+### Auto-assign issue based on commit mention
+
+When a commit mentions(fixes, closes) an issue, auto assign unassigned issues.


autoassign who to which unassigned issues? This is fuzzy

sils · 2018-05-14T14:16:48Z

cEP-0024.md

+
+When a reviewer reviews a PR and either he approves changes or request changes
+and leaves it there, but PR would be still in the review queue, so there should
+be an automation to mark approve label if reviewer approves changes and mark


not only approve label, also setting the wip label when people start unacking and/or commeting on the source code as well as on CI fail possibly?

sils · 2018-05-14T14:18:05Z

cEP-0024.md

+be a lot of pain. So, a plugin to ban a user from using GitMate further and
+removing his rights at that very moment will be helpful. Ban user plugin,
+which can be configured in gitmate UI will be created within this project.
+Removing that user from the org will be configurable.


wait, GitMate isn't supposed to improve on the GitHub permission system. What's against just removing the user from the org thus disabling all rights to GitMate for features that check for authentication?

sils · 2018-05-14T14:18:53Z

cEP-0024.md

+
+### Auto-review merge conflicts
+
+Check for merge conflicts and give link to documentation on how to fix it.


can you be more specific?

e.g. like probot https://github.com/clarkbw/no-merge-commits ;-)

sils · 2018-05-14T14:19:19Z

cEP-0024.md

+> @gitmate-bot assign
+
+  @user, you have been assigned
+


what's this newline for?

sils · 2018-05-14T14:19:55Z

cEP-0024.md

+Assign issue when a user comments on an issue requesting for an `assignment`
+to that issue. Will support settings for each team like limit team to work on
+issues with specific set of labels, limit number of issues of specified label,
+a team member can work on.


doesn't corobo already do this? What's the problem with that? (The problem should be at least explained here if there is one.)

Vamshi99 · 2018-07-29T10:08:44Z

@jayvdb Done

jayvdb · 2018-07-30T07:33:00Z

cEP-0024.md

+or when there is any CI failure.
+
+GitMate will consider only maintainer reviews, to consider developer reviews,
+GitMate has use teams, but using teams in GitMate is not a part of my project.


GitMate has use teams -> GitMate and IGitt would need to add support for teams

my project -> this project

jayvdb · 2018-07-30T07:33:27Z

cEP-0024.md

+needs a better mechanism to clear review queue when any maintainer reviews PR
+or when there is any CI failure.
+
+GitMate will consider only maintainer reviews, to consider developer reviews,


full stop after "maintainer reviews". Then start a new sentence

jayvdb · 2018-07-30T11:07:25Z

cEP-0024.md

+GitMate may consider using teams in the future.
+
+When a PR is opened, updated or when any maintainer reviews the PR, GitMate
+will automatically mark labels, as per the following conditions:


"automatically mark labels" isnt clear.

I guess "add labels" ... ?

Also should say that it will remove the "pending review" label, which still isnt mentioned anywhere in this section

jayvdb · 2018-07-30T11:10:06Z

cEP-0024.md

+### Notify Merge conflicts in a PR
+
+When a PR is opened or updated, check for merge conflicts in it,
+if there are any conflicts, mark the PR with a certain label (configurable) and


it should also remove the "pending review" label?

gitmate-bot · 2018-07-30T11:15:11Z

cEP-0024.md

+so that maintainers can identify these type of PRs and GitMate will comment
+on the PR informing the author of the PR to get invited to the organization
+before working on any issue. After the newcomer has accepted the invite,
+he/she needs to re-push to remove the label added by GitMate. 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp3usw2_q1/cEP-0024.md +++ b/tmp/tmp3usw2_q1/cEP-0024.md @@ -86,7 +86,7 @@ so that maintainers can identify these type of PRs and GitMate will comment on the PR informing the author of the PR to get invited to the organization before working on any issue. After the newcomer has accepted the invite, -he/she needs to re-push to remove the label added by GitMate. +he/she needs to re-push to remove the label added by GitMate. coala can configure this plugin as:

gitmate-bot · 2018-07-30T11:37:39Z

cEP-0024.md

+so that maintainers can identify these type of PRs and GitMate will comment
+on the PR informing the author of the PR to get invited to the organization
+before working on any issue. After the newcomer has accepted the invite,
+he/she needs to re-push to remove the label added by GitMate. 


Line contains following spacing inconsistencies:

Trailing whitespaces.

Origin: SpaceConsistencyBear, Section: spacing.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpiwyz2038/cEP-0024.md +++ b/tmp/tmpiwyz2038/cEP-0024.md @@ -86,7 +86,7 @@ so that maintainers can identify these type of PRs and GitMate will comment on the PR informing the author of the PR to get invited to the organization before working on any issue. After the newcomer has accepted the invite, -he/she needs to re-push to remove the label added by GitMate. +he/she needs to re-push to remove the label added by GitMate. coala can configure this plugin as:

jayvdb · 2018-07-30T22:34:16Z

ack 42b9daa

jayvdb · 2018-07-30T22:34:33Z

@gitmate-bot rebase

gitmate-bot · 2018-07-30T22:34:36Z

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

Closes coala#141

gitmate-bot · 2018-07-30T22:36:05Z

Automated rebase with GitMate.io was successful! 🎉

jayvdb · 2018-07-30T22:36:51Z

reack a4b2ab3

jayvdb · 2018-07-30T22:37:51Z

ack a4b2ab3

jayvdb · 2018-07-30T22:38:07Z

@gitmate-bot ff

gitmate-bot · 2018-07-30T22:38:10Z

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

gitmate-bot · 2018-07-30T22:39:12Z

Automated fastforward with GitMate.io was successful! 🎉

gitmate-bot added process/pending review size/XS labels May 10, 2018

gitmate-bot reviewed May 10, 2018

View reviewed changes

Vamshi99 force-pushed the gitmate branch from 38d94e3 to e528c41 Compare May 10, 2018 15:46

gitmate-bot reviewed May 10, 2018

View reviewed changes

sks444 reviewed May 10, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels May 11, 2018

jayvdb mentioned this pull request May 11, 2018

cEP-0019.md: Meta-review system #123

Merged

jayvdb reviewed May 11, 2018

View reviewed changes

jayvdb requested changes May 11, 2018

View reviewed changes

gitmate-bot added the New cEP label May 12, 2018

Vamshi99 force-pushed the gitmate branch from e528c41 to a6c55a6 Compare May 12, 2018 13:46

gitmate-bot added process/pending review and removed process/wip labels May 12, 2018

gitmate-bot reviewed May 12, 2018

View reviewed changes

Vamshi99 force-pushed the gitmate branch from a6c55a6 to 561724a Compare May 12, 2018 13:52

gitmate-bot reviewed May 12, 2018

View reviewed changes

Vamshi99 force-pushed the gitmate branch from 561724a to 7d57dfd Compare May 12, 2018 13:55

gitmate-bot reviewed May 12, 2018

View reviewed changes

sils requested changes May 14, 2018

View reviewed changes

sils added process/wip and removed process/pending review labels May 14, 2018

Vamshi99 force-pushed the gitmate branch from 7d57dfd to 0bbfc37 Compare May 14, 2018 18:05

jayvdb requested changes Jul 30, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Jul 30, 2018

Vamshi99 force-pushed the gitmate branch from f730b81 to 478494b Compare July 30, 2018 11:13

gitmate-bot added process/pending review and removed process/wip labels Jul 30, 2018

gitmate-bot reviewed Jul 30, 2018

View reviewed changes

Vamshi99 force-pushed the gitmate branch from 478494b to 65abbb9 Compare July 30, 2018 11:36

gitmate-bot reviewed Jul 30, 2018

View reviewed changes

Vamshi99 force-pushed the gitmate branch from 65abbb9 to 42b9daa Compare July 30, 2018 11:44

jayvdb approved these changes Jul 30, 2018

View reviewed changes

gitmate-bot added process/approved and removed process/pending review labels Jul 30, 2018

cEP-0024.md: Add cEP for GitMate Plugins

a4b2ab3

Closes coala#141

gitmate-bot force-pushed the gitmate branch from 42b9daa to a4b2ab3 Compare July 30, 2018 22:35

gitmate-bot added process/pending review and removed process/approved labels Jul 30, 2018

gitmate-bot added process/approved and removed process/pending review labels Jul 30, 2018

gitmate-bot merged commit a4b2ab3 into coala:master Jul 30, 2018

		@@ -0,0 +1,84 @@
		Implement GitMate automations and plugins for coala

		@@ -0,0 +1,82 @@
		#Implement GitMate automations and plugins for coala


		### Auto-assign issue based on commit mention

		When a commit mentions(fixes,closes) an issue, auto assign unassigned issues.


		### Assign Plugin

		Assign issue when a user comments on an issue requesting for an assignemnet


		## Introduction

		GitMate.io is an automation tool for developers. While it works well, there are


		### Auto-mark PR with necessary labels as per the reviews done

		When a reviewer reviews a PR and either he approves changes or request changes


		Check for merge conflicts and give link to documentation on how to fix it.

		## Mockups


		### Auto-review merge conflicts

		Check for merge conflicts and give link to documentation on how to fix it.


		### Auto-assign issue based on commit mention

		When a commit mentions(fixes, closes) an issue, auto assign unassigned issues.

cEP-0024.md: GitMate Plugins #142

cEP-0024.md: GitMate Plugins #142

Conversation

Vamshi99 commented May 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Auto-review merge conflicts

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Auto-review merge conflicts

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Auto-review merge conflicts

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Vamshi99 commented Jul 29, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayvdb commented Jul 30, 2018

jayvdb commented Jul 30, 2018

gitmate-bot commented Jul 30, 2018

gitmate-bot commented Jul 30, 2018

jayvdb commented Jul 30, 2018

jayvdb commented Jul 30, 2018

jayvdb commented Jul 30, 2018

gitmate-bot commented Jul 30, 2018

gitmate-bot commented Jul 30, 2018