Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Old version warning even when the latest is installed #48

Open
RohanVB opened this issue Mar 15, 2017 · 5 comments
Open

Old version warning even when the latest is installed #48

RohanVB opened this issue Mar 15, 2017 · 5 comments
Labels
difficulty/low
Milestone
3.1.0

Comments

@RohanVB
Copy link
Member

RohanVB commented Mar 15, 2017 •
edited

screen shot 2017-03-15 at 3 26 52 pm

$ coala --version
0.10.0

We could also add what the current version is in the warning.
@ed4140
Copy link
Contributor

ed4140 commented Mar 17, 2017

Assign this one to me too, please

ed4140 added a commit to ed4140/coala-atom that referenced this issue Mar 28, 2017
@ed4140
main.coffee: Fix old version warning
14feca4 
Fix old version warning even when the latest is installed.
Versions were compared as strings, so '0.10.0' was less than '0.9.1'
Replaced comparison with a proper function.
Closes coala#48
ed4140 added a commit to ed4140/coala-atom that referenced this issue Mar 29, 2017
@ed4140
main.coffee: Fix old version warning
a7dc769 
Fix old version warning even when the latest is installed.
Versions were compared as strings, so '0.10.0' was less than '0.9.1'
Replaced comparison with a proper function.
Closes coala#48
@ed4140 ed4140 mentioned this issue Apr 3, 2017
Closed
ed4140 added a commit to ed4140/coala-atom that referenced this issue Apr 3, 2017
@ed4140
main.coffee: Fix old version warning
40083c1 
Fix old version warning even when the latest is installed.
Versions were compared as strings, so '0.10.0' was less than '0.9.1'
Replaced comparison with a proper function.
Closes coala#48
@RohanVB RohanVB modified the milestone: 3.1.0 Apr 23, 2017
@Kagamihime
Copy link

Kagamihime commented Jan 28, 2018 •
edited

This issue seems to be inactive. Could I take it, please?
Cc @Makman2

@Makman2
Copy link
Member

Makman2 commented Jan 28, 2018

Unassigned due to inactivity.

Kagamihime added a commit to Kagamihime/coala-atom that referenced this issue Jan 31, 2018
@Kagamihime
main.coffee: Add the current version in warnings
64b758d 
This adds the current version of coala in the warning
message when it is outdated.

Closes coala#48
Kagamihime added a commit to Kagamihime/coala-atom that referenced this issue Jan 31, 2018
@Kagamihime
main.coffee: Fix old version warning
9152296 
This fixes the old version warning by properly compare
the version numbers between `result` and `COALA_MIN_VERSION`
instead of comparing these strings lexicographically.

Closes coala#48
@Kagamihime Kagamihime mentioned this issue Jan 31, 2018
Open
Kagamihime added a commit to Kagamihime/coala-atom that referenced this issue Jan 31, 2018
@Kagamihime
main.coffee: Fix old version warning
bcb9a66 
This fixes the old version warning by properly compare
the version numbers between `result` and `COALA_MIN_VERSION`
instead of comparing these strings lexicographically.

Closes coala#48
Kagamihime added a commit to Kagamihime/coala-atom that referenced this issue Jan 31, 2018
@Kagamihime
main.coffee: Fix old version warning
ae29839 
This fixes the old version warning by properly compare
the version numbers between `result` and `COALA_MIN_VERSION`
instead of comparing these strings lexicographically.

Closes coala#48
Kagamihime added a commit to Kagamihime/coala-atom that referenced this issue Feb 1, 2018
@Kagamihime
main.coffee: Fix old version warning
a2bfabe 
This fixes the old version warning by properly comparing
the version numbers between `result` and `COALA_MIN_VERSION`
instead of comparing these strings lexicographically.

Closes coala#48
jayvdb pushed a commit to Kagamihime/coala-atom that referenced this issue Apr 18, 2018
@Kagamihime @gitmate-bot
main.coffee: Add the current version in warnings
76332ca 
This adds the current version of coala in the warning
message when it is outdated.

Closes coala#48
jayvdb pushed a commit to Kagamihime/coala-atom that referenced this issue Apr 18, 2018
@Kagamihime @gitmate-bot
main.coffee: Fix old version warning
2d05590 
This fixes the old version warning by properly comparing
the version numbers between `result` and `COALA_MIN_VERSION`
instead of comparing these strings lexicographically.

Closes coala#48
@gadlopes
Copy link

Still having the same problem:
Atom 1.35.1
atom-Coala 0.3.0
coala 0.11.0

@gadlopes
Copy link

Deprecation cop is complaining:

Argument to path.dirname must be a string

Object.dirname (/Applications/Atom.app/Contents/Resources/app.asar/src/electron-shims.js:9:10)
Object.lint (/Users/glopes/.atom/packages/coala/lib/main.coffee:58:25)
a.factory (/Users/glopes/.atom/packages/atom-ide-ui/modules/atom-ide-ui/pkg/atom-ide-diagnostics/lib/services/LinterAdapter.js:309:42)
a._callFactory (/Users/glopes/.atom/packages/atom-ide-ui/node_modules/rxjs/bundles/Rx.min.js:107:23)
a.tryDefer (/Users/glopes/.atom/packages/atom-ide-ui/node_modules/rxjs/bundles/Rx.min.js:106:442)
new a (/Users/glopes/.atom/packages/atom-ide-ui/node_modules/rxjs/bundles/Rx.min.js:106:383)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty/low
Milestone
3.1.0
Development

No branches or pull requests
5 participants
@Makman2 @ed4140 @RohanVB @Kagamihime @gadlopes