Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify tests for URLHeadBear dependents to support user-agent header #2881

Open
Akhelesh opened this issue Feb 21, 2019 · 2 comments
Open

Modify tests for URLHeadBear dependents to support user-agent header #2881

Akhelesh opened this issue Feb 21, 2019 · 2 comments

Comments

@Akhelesh
Copy link

#2879 PR adds a user-agent header to the request made by URLHeadBear. The HTTPSBearTest and InvalidLinkBearTest cause the build to fail as they depend on the URLHeadBear.

What to do:
Add user-agent header used by the URLHeadBear to the requests made by these tests.
@Akhelesh
Copy link
Author

@jayvdb Please assign this issue to me. It's related to the PR I am working on.

@KVGarg
Copy link
Contributor

KVGarg commented Apr 13, 2019

@Akhelesh Please make changes in the created PR #2879 only! There is no need of creating a new issue for adding a test. The test has to be added in that PR only as its part of the issue #1203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KVGarg @Akhelesh