Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proper deployment keys #145

Merged
merged 1 commit into from Dec 5, 2017
Merged

Conversation

yukiisbored
Copy link
Member

@yukiisbored yukiisbored commented Dec 5, 2017

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2017

"proper" sounds like the old keys were incorrect . "Set new deployment keys"

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2017

Whoops; I misunderstood. Please add a short blurb to the commit to mention this is fixing the prior commit

@yukiisbored
Copy link
Member Author

@jayvdb Done.

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2017

ack 00fe0c0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants