-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Running modes in coala-quickstart #90
Comments
How are we going to ask users for the non-optional setting values 😅 |
input fields, text boxies or radio buttons
…On May 8, 2017 2:18 PM, "Satwik Kansal" ***@***.***> wrote:
Then ask users for the optional/non-optional settings of those bears, and
send this to the backend saving it in a settings.json file.
How are we going to ask users for the non-optional setting values 😅
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMalylXJDpWPIRQb7SuPE7RbgOk0zXbQks5r3tbkgaJpZM4NThya>
.
|
coala.io already has the name of settings of all the bears (coala.io/languages), we can hence attach input fields to setting name, For eg, suppose the backend returns,
Then we show the user a form and take inputs,
And then send these to the backend. |
I see, approach seems good to me |
Also not sure if it's relevant but here's what I had in my GSoC proposal
|
Let me know what do you think of this, Presently We can make a function in ConsoleInteraction
|
Sorry why do you want to ask the user for settings and pass them to coala-incremental? This doesn't make sense at all; quockstart is a tool to auto generate settings and not to run coala, where's the point in giving it settings? And it already has a ci mode. |
The plan is to add two options in quickstart, a |
agree but we'll have to find a better name for sections_only, maybe like allow-incpmplete-sections or so |
Sounds nice :) Just couple of doubts :P
How would you differentiate between a usable and unusable bears in the coafile? I think we'll have to come up with a syntactical representation in "intermediate-coafile" to mark and identify the sections with unusable bears while parsing. Also, what is the difference between "coala online" and "webservices" :P (to me it seems like one is "frontend" and other one is "backend") |
Right now it removes the unusable bears with a function that specifically does this tasks. Unusable bears here implies those bears which will ask for setting, so that is why they are unuseable in normal CI mode. But with Actually webServices has an endpoint |
Ah, okay... So the interaction is very similar to CLI interaction in quickstart. The intermediate |
Yeah exactly
…On May 31, 2017 10:12 PM, "Satwik Kansal" ***@***.***> wrote:
We don't need to differentiate then right? we will just send all the bears
to user and ask for their settings. did I understood the question correctly?
Ah, okay... So the interaction is very similar to CLI interaction in
quickstart.
The intermediate coafile only has sections with bear names and then we
can ask for non-optional settings in the web interface, right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMalyg6tiixsdE89aULZ7gml9FN8oFJnks5r_ZhggaJpZM4NThya>
.
|
webServices Status
webServices doesn't support all the bears presently. It doesn't support the bears which have nonoptional settings. As a solution, what we can do is run coala-quickstart on the project and get relevant bears, by running quickstart in a
--relevant-bears
modeThen ask users for the optional/non-optional settings of those bears, and send this to the backend saving it in a settings.json file.
Then coala-quickstart would run in
--get-bears-settings = settings.json
mode, and return the frontend a coafile, with bear settings.Users will now click a "Run coala" button (or we can do that without asking user ?) and then we run coala on the project with the generated coafile, which has optional/non optional settings for bears and thus doesn't break the module.
Essentialy, frontend will send flags to the backend which will then decide the running mode of coala-quickstart.
cc @adtac @satwikkansal Thoughts?
The text was updated successfully, but these errors were encountered: