Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coala-format new string option : severity_str #1313

Closed
AbdealiLoKo opened this issue Feb 8, 2016 · 14 comments
Closed

coala-format new string option : severity_str #1313

AbdealiLoKo opened this issue Feb 8, 2016 · 14 comments

Comments

@AbdealiLoKo
Copy link
Contributor

Currently, severity gives the formatted output as a integer.
severity_str can be used to give it as a string (Info, Normal, Major).

So, then people can use which ever they prefer.

@shubh1m
Copy link
Member

shubh1m commented Feb 8, 2016

@AbdealiJK I am new to coala and it would be helpful if you elaborate this.

@AbdealiLoKo
Copy link
Contributor Author

@iamshubh22 hey there !
We have a file named RESULT_SEVEIRTY.py which contains an Enum (enumeration) for all the severities we have in coala. As you may know, enums are essentially ints which have a string associated to it.

Currently we have 3 severities: Info (0), Normal (1), and Major (2)

Now, in coala-format, we can specify how we want coala's results to be formatted using the format_str setting (try: coala-format -S --format_str="{line} - {severity} - {file} - {message}")

Example output:
3 - 1 - /home/ajk/Documents/coala/test.py - The code does not comply to PEP8.

And if you notice the output of coala-format, the output for the "severity" is an integer (which is the integer part of the Enum). I propose that we add a "severity_str" which would allow me to get something like this:
3 - Normal - /home/ajk/Documents/coala/test.py - The code does not comply to PEP8.
When I run coala-format -S --format_str="{line} - {severity_str} - {file} - {message}"

@shubh1m
Copy link
Member

shubh1m commented Feb 8, 2016

@AbdealiJK Got it.

@sils
Copy link
Member

sils commented Feb 14, 2016

@yash14123 ping us if you need assistance :)

@theaverageguy
Copy link
Contributor

I do. :(

On Sun, Feb 14, 2016 at 7:10 PM, Lasse Schuirmann notifications@github.com
wrote:

@yash14123 https://github.com/yash14123 ping us if you need assistance
:)


Reply to this email directly or view it on GitHub
#1313 (comment)
.

@sils
Copy link
Member

sils commented Feb 14, 2016

@yash14123 we're around at https://gitter.im/coala-analyzer/coala to help you :)

@theaverageguy
Copy link
Contributor

Will catch up with you in an hour.

On Sun, Feb 14, 2016 at 7:21 PM, Lasse Schuirmann notifications@github.com
wrote:

@yash14123 https://github.com/yash14123 we're around at
https://gitter.im/coala-analyzer/coala to help you :)


Reply to this email directly or view it on GitHub
#1313 (comment)
.

@sils
Copy link
Member

sils commented Feb 14, 2016

I'll be away then, others will be around for sure. Try pinging @AbdealiJK

2016-02-14 14:53 GMT+01:00 yash14123 notifications@github.com:

Will catch up with you in an hour.

On Sun, Feb 14, 2016 at 7:21 PM, Lasse Schuirmann <
notifications@github.com>
wrote:

@yash14123 https://github.com/yash14123 we're around at
https://gitter.im/coala-analyzer/coala to help you :)


Reply to this email directly or view it on GitHub
<
#1313 (comment)

.


Reply to this email directly or view it on GitHub
#1313 (comment)
.

@sils
Copy link
Member

sils commented Feb 24, 2016

@yash14123 please ping back todayish, otherwise we may reassign this issue.

@sils
Copy link
Member

sils commented Feb 24, 2016

Just a ping is sufficient to know you still intend to work on it, you don't need to actually do it today.

@theaverageguy
Copy link
Contributor

I am consumed with the mid-semesters. I really apologize for not being
active . They end in about 4 days. If someone else is willing to work on
it, please reassign.
Sorry for the delay. Real tough exams in India u know :(

On Wed, Feb 24, 2016 at 11:16 PM, Lasse Schuirmann <notifications@github.com

wrote:

Just a ping is sufficient to know you still intend to work on it, you
don't need to actually do it today.


Reply to this email directly or view it on GitHub
#1313 (comment)
.

@sils
Copy link
Member

sils commented Feb 24, 2016

@yash14123 ok I'm freeing this bug then, feel free to approach us whenever you like though ;)

@sils
Copy link
Member

sils commented Feb 24, 2016

@SanketDG you've asked about this, if you have some kind of interest on it, feel free to look into it.

@SanketDG
Copy link
Member

@sils1297 yes assign this to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants