Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coala shouldn't store previous input values in case of failed execution #1825

Closed
srisankethu opened this issue Mar 6, 2016 · 2 comments
Closed

Comments

@srisankethu
Copy link
Member

Noticed case:

I tried opening affected files in an editor.I gave an invalid editor name and the execution failed.But when I tried to open the editor again, i get an error because coala takes in the 'number of action' and applies it to check the editor name.

@Makman2
Copy link
Member

Makman2 commented Mar 6, 2016

so for clarification:
After a failed OpenEditorAction, the editor-name is saved for the next try. So i if the user retries now, he isn't asked for the editor again and coala tries to reopen the invalid editor again, which immediately leads to failing again.

@srisankethu
Copy link
Member Author

Yes!...Can you assign this to me?

srisankethu pushed a commit to srisankethu/coala that referenced this issue Mar 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants