Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warnings shouldn't be printed so many times #3165

Closed
underyx opened this issue Dec 6, 2016 · 2 comments
Closed

Deprecation warnings shouldn't be printed so many times #3165

underyx opened this issue Dec 6, 2016 · 2 comments

Comments

@underyx
Copy link
Member

underyx commented Dec 6, 2016 

[WARNING][10:16:07] The setting `ci_keywords` is deprecated. Please use `keywords` instead.
[WARNING][10:16:07] The setting `ci_keywords` is deprecated. Please use `keywords` instead.
[WARNING][10:16:07] The setting `ci_keywords` is deprecated. Please use `keywords` instead.
[WARNING][10:16:07] The setting `ci_keywords` is deprecated. Please use `keywords` instead.
[WARNING][10:16:07] The setting `ci_keywords` is deprecated. Please use `keywords` instead.
[WARNING][10:16:07] The setting `ci_keywords` is deprecated. Please use `keywords` instead.
[WARNING][10:16:07] The setting `ci_keywords` is deprecated. Please use `keywords` instead.
[WARNING][10:16:07] The setting `ci_keywords` is deprecated. Please use `keywords` instead.
[WARNING][10:16:07] The setting `ci_keywords` is deprecated. Please use `keywords` instead.

I'm seeing hundreds of these lines and they make parsing the output near impossible.
@sils
Copy link
Member

sils commented Dec 6, 2016

right, the function could have global state and caching which param combination was already logged but I wonder if that'll work as they're run in different processes...

@underyx
Copy link
Member Author

underyx commented Dec 6, 2016

Or we could move deprecation checking up a few levels, and do it along with the config file parsing?

@adtac adtac mentioned this issue Dec 9, 2016
Closed
6 tasks
adtac added a commit that referenced this issue Dec 9, 2016
@adtac
bearlib: Cache deprecation message
50608f9 
Annoying when the same message is logged hundreds of times.

Fixes #3165
@rultor rultor closed this as completed in a22ec25 Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bearlib: Cache deprecation message coala/coala
2 participants
@underyx @sils