Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of autoapply in run_coala causes difficulty when using coala in a serverside checking application #3212

Closed
Mixih opened this issue Dec 10, 2016 · 5 comments
Closed

Removal of autoapply in run_coala causes difficulty when using coala in a serverside checking application #3212

Mixih opened this issue Dec 10, 2016 · 5 comments
Labels
area/usability importance/critical status/needs design

Comments

@Mixih
Copy link
Member

Mixih commented Dec 10, 2016

The removal of auto-apply parameter from run_coala means that coala still auto applies applies it's actions when run from run_coala. We need to have a way for the user to disable auto-patch application so coala can be used to show code errors, not fix them. (This almost broke gitmate)
@Mixih Mixih mentioned this issue Dec 10, 2016
Closed
@Mixih Mixih mentioned this issue Dec 10, 2016
Closed
6 tasks
Mixih added a commit to Mixih/coala that referenced this issue Dec 10, 2016
@Mixih
.coafile: Remove default_action statements
35cec5d 
The latest version of coala in gitmate will not raise issues for
things thatget a patch action applied(eg line length, spacing).
To temporarily fix this, the default_action statments have been
removed which will require devs to fix these issues manually
(which they should be doing anyways).

Closes coala#3213
Related to coala#3212
@sils
Copy link
Member

sils commented Dec 10, 2016

marking critical importance because this affects gitmate and thus also us!

@sils
Copy link
Member

sils commented Dec 10, 2016

CC @fneu @seblat or anyone really, if you have time, fix this please

Mixih added a commit that referenced this issue Dec 10, 2016
@Mixih
.coafile: Remove default_action statements
4e2585e 
The latest version of coala in gitmate will not raise issues for
things thatget a patch action applied(eg line length, spacing).
To temporarily fix this, the default_action statments have been
removed which will require devs to fix these issues manually
(which they should be doing anyways).

Closes #3213
Related to #3212
@Mixih
Copy link
Member Author

Mixih commented Dec 10, 2016

decided to add autoapply parameter. default it to true, when false, don't apply action.
per gitter https://gitter.im/coala/coala?at=584c5c47c29531ac5d480430

@sils sils mentioned this issue Dec 10, 2016
Merged
@Mixih
Copy link
Member Author

Mixih commented Dec 11, 2016 •
edited

I advise we patch coala-incremental for now as it's critical and testing this will be a mess. It's appearently a tiny workaround there that will be easy to implement. https://gitter.im/coala/coala?at=584c59ccaeb49008046ff5d0

@Mixih
Copy link
Member Author

Mixih commented Dec 23, 2016 •
edited

#3216 closes this. Due to a failure on my part, I failed to catch the multiple commit issues before merging. sigh

@Mixih Mixih closed this as completed Dec 23, 2016
Mixih pushed a commit to Mixih/coala that referenced this issue Dec 25, 2016
@sils @Mixih
run_coala: Add autoapply argument
51b73da 
This allows serverside implementations of coala to ignore
the default_actions in coafiles allowing all issues to be output

Closes coala#3212
(cherry picked from commit 06a772f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/usability importance/critical status/needs design
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sils @Mixih