Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiffTest failing on CI #5045

Closed
Makman2 opened this issue Jan 5, 2018 · 2 comments
Closed

DiffTest failing on CI #5045

Makman2 opened this issue Jan 5, 2018 · 2 comments
Assignees
@Makman2
Labels
area/CI difficulty/newcomer importance/critical type/bug

Comments

@Makman2
Copy link
Member

Makman2 commented Jan 5, 2018

See build https://travis-ci.org/coala/coala/jobs/325392018

Seems there was a recent update to 0.5.5 of the unidiff module on 3rd January 2018. Fixing the version below 0.5.5 should fix ti.
@Makman2 Makman2 self-assigned this Jan 5, 2018
@sils
Copy link
Member

sils commented Jan 5, 2018

@Makman2 is there an upstream issue?

@Makman2
Copy link
Member Author

Makman2 commented Jan 5, 2018

Filed upstream issue: matiasb/python-unidiff#50

This was referenced Jan 5, 2018
Merged
Merged
Mixih pushed a commit to Mixih/coala that referenced this issue Feb 19, 2018
@Makman2 @Mixih
requirements.txt: Limit unidiff version
a321205 
unidiff 0.5.5 breaks our builds.

Fixes coala#5045

(cherry-picked from 7dbe44b)
Mixih pushed a commit to Mixih/coala that referenced this issue Feb 19, 2018
@Makman2 @Mixih
requirements.txt: Limit unidiff version
a54c11b 
unidiff 0.5.5 breaks our builds.

Fixes coala#5045

(cherry-picked from 7dbe44b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Makman2 Makman2

Labels
area/CI difficulty/newcomer importance/critical type/bug
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sils @Makman2