Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail to reach 100% code coverage locally, though CI build passes. #5206

Open
nvzard opened this issue Feb 26, 2018 · 5 comments · May be fixed by #5216
Open

Tests fail to reach 100% code coverage locally, though CI build passes. #5206

nvzard opened this issue Feb 26, 2018 · 5 comments · May be fixed by #5216
Assignees
@harshhx17
Labels
area/tests difficulty/low importance/high type/bug

Comments

@nvzard
Copy link
Member

nvzard commented Feb 26, 2018 •
edited

Here are the local logs: https://gist.github.com/nvzard/ef99b21d57a429b08760347f46edf12e

coalib/misc/CachingUtilities.py       76      1     20      1    98%   171, 168->171
@Makman2
Copy link
Member

Makman2 commented Feb 26, 2018

Task is to write a test filling the gap.

@harshhx17
Copy link
Contributor

Can this issue be assigned to me @Makman2
😄

@nvzard
Copy link
Member Author

nvzard commented Feb 27, 2018

I was testing something on docker and found this,
Tests give 100% coverage when "coverage~=4.2" but fail to give 100% when "coverage~=4.3.4"
Here are the logs: https://pastebin.com/rzXyS6TM

@harshhx17
Copy link
Contributor

Thanks @nvzard 🤔

harshhx17 added a commit to harshhx17/coala that referenced this issue Feb 27, 2018
@harshhx17
CachingUtilitiesTest.py: Add test for local build
249a8bb 
This adds test to CachingUtilitiesTest.py for the code in
CachingUtilities.py which runs when coala is run for the first
time on the project

Fixes coala#5206
@harshhx17 harshhx17 linked a pull request Feb 27, 2018 that will close this issue
Open
2 tasks
harshhx17 added a commit to harshhx17/coala that referenced this issue Feb 28, 2018
@harshhx17
CachingUtilitiesTest.py: Add test for local build
bf7c625 
Add test for CachingUtilities when coala is run for the first
time on the project.

Fixes coala#5206
@adtac
Copy link
Member

adtac commented Mar 11, 2018

I swear there was another issue related to this from a long time ago (I introduced the bug, I should know). I tried searching and I can't find it. Guess this is the one now :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshhx17 harshhx17

Labels
area/tests difficulty/low importance/high type/bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CachingUtilitiesTest.py: Add test for local build harshhx17/coala
4 participants
@Makman2 @adtac @nvzard @harshhx17