Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight whitespace #606

Closed
Makman2 opened this issue May 29, 2015 · 3 comments
Closed

Highlight whitespace #606

Makman2 opened this issue May 29, 2015 · 3 comments

Comments

@Makman2
Copy link
Member

Makman2 commented May 29, 2015

Now the the trailing whitespace is invisible when the bear finds one. We should do it like git and highlight it with a red color. Also I would make a specific message for the user, that it was concretely a trailing whitespace the bear found.
Current output:

/home/mak/dev/coala/coalib/tests/parsing/StringProcessingTest.py
| ...| ...| 
|   6|   6| from coalib.parsing.StringProcessing import unescape
|   7|   7| from coalib.parsing.StringProcessing import position_is_escaped
|   8|   8| 
|   9|   9| # TODO If no tests are performed, insert a skip here (if it doesn't disarm 
|    |    | [NORMAL] SpaceConsistencyBear:
|    |    | Line contains spacing inconsistencies.
|    |    | The following options are applicable to this result:
|    |    |  0: Do nothing.
|    |    |  1: Open a temporary clone of the file in an editor.
|    |    |  2: Apply the patch automatically.
|    |    | Please enter the number of the action you want to execute. 2

Line 9 contains the trailing whitespace btw.

@sils
Copy link
Member

sils commented May 30, 2015

ah yeah we wanted that anyway, we wanted to replace spaces with a unicode
multiplication dot and tabs with an arrow or so highlighting it colorly :)
maybe there's another bug but this one is good too

2015-05-29 23:09 GMT+02:00 Makman2 notifications@github.com:

Now the the trailing whitespace is invisible when the bear founds one. We
should do it like git and highlight it with a red color. Also I would make
a specific message for the user, that it was concretely a trailing
whitespace the bear found.
Current output:

/home/mak/dev/coala/coalib/tests/parsing/StringProcessingTest.py
| ...| ...|
| 6| 6| from coalib.parsing.StringProcessing import unescape
| 7| 7| from coalib.parsing.StringProcessing import position_is_escaped
| 8| 8|
| 9| 9| # TODO If no tests are performed, insert a skip here (if it doesn't disarm
| | | [NORMAL] SpaceConsistencyBear:
| | | Line contains spacing inconsistencies.
| | | The following options are applicable to this result:
| | | 0: Do nothing.
| | | 1: Open a temporary clone of the file in an editor.
| | | 2: Apply the patch automatically.
| | | Please enter the number of the action you want to execute. 2

Line 9 contains the trailing whitespace btw.

Want to back this issue? Post a bounty on it!
https://www.bountysource.com/issues/18751060-spaceconsistencybear-highlight-trailing-whitespace?utm_campaign=plugin&utm_content=tracker%2F2228228&utm_medium=issues&utm_source=github

We accept bounties via Bountysource
https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F2228228&utm_medium=issues&utm_source=github
.

Reply to this email directly or view it on GitHub
#606.

@sils
Copy link
Member

sils commented May 30, 2015

I think thats a general CLI feature, not tied to any bear

@sils sils changed the title SpaceConsistencyBear: Highlight trailing whitespace Highlight whitespace May 30, 2015
@sils
Copy link
Member

sils commented May 30, 2015

I filed #609 for you

@Makman2 Makman2 added this to the 0.3 alpha milestone Jul 26, 2015
@sils sils removed this from the 0.3 alpha milestone Nov 8, 2015
@rultor rultor closed this as completed in 71d593b Feb 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants