towards pytest - continuation #1183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will simplify test skipping for clang related tests.
sils
force-pushed
the
sils/pytest
branch
2 times, most recently
from
d07613d
to
be866ac
Compare
sils
changed the title
This also has the nice side effect that not all test cases are skipped if clang is not installed.
We don't want it to be executed if dbus isn't available.
Closed
|
@sils1297 can't you make a skip-function for the dbus stuff? less code duplication^^ |
This simplifies our test utilities since we switched to builtin unittest test skipping.
We don't need it anymore.
This way pytest will ignore our Test* classes and not issue warnings for them.
The official documentation can explain this better than we can, this is useless documentation to maintain.
|
@Makman2 it's not really duplication, it covers different imports everywhere, hard to put into a function. |
|
can't you just import dbus completely and see whether it fails or not? That could fit into a function^^ |
|
@Makman2 then the other imports will fail and everything will error out again |
Makman2
added
process/approved
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.