Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makman2/relnotes #5186

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Makman2/relnotes #5186

wants to merge 2 commits into from

Conversation

Makman2
Copy link
Member

@Makman2 Makman2 commented Feb 19, 2018

No description provided.


- Write output to empty file instead of appending.
When ``--output`` option is specified, write output of coala to a
fresh file. This avoid file corruption with for certain output formats
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you intended to put a / between 'with' or 'for' here. Or use one of them('with' or 'for'). 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh indeed 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I remember I've copied this from the commit messages, seems a few grammatical mistakes sneaked in ;) )

@123vivekr
Copy link
Member

Commit message should follow commit guidelines.
Please fix your commit message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

6 participants