Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coala_main.py: Provides options with -A tag #5222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Naveenaidu
Copy link
Member

@Naveenaidu Naveenaidu commented Feb 28, 2018

This allows selection of the actions when the -A
tag is used.The actions can now be selected with
the appropriate number or character.

Fixes: #5166

The previous Pull request is in the #5198

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@gitmate-bot
Copy link
Collaborator

Comment on 962a578, file coalib/coala_main.py, line 11.

This file contains unused source code.

Origin: PyUnusedCodeBear, Section: flakes.

The issue can be fixed by applying the following patch:

--- a/tmp/tmphm7d0tfk/coalib/coala_main.py
+++ b/tmp/tmphm7d0tfk/coalib/coala_main.py
@@ -8,12 +8,6 @@
 from coalib.output.Logging import CounterHandler
 from coalib.processes.Processing import execute_section, simplify_section_result
 from coalib.settings.ConfigurationGathering import gather_configuration
-from coalib.results.result_actions.DoNothingAction import DoNothingAction
-from coalib.results.result_actions.ShowPatchAction import ShowPatchAction
-from coalib.results.result_actions.ApplyPatchAction import ApplyPatchAction
-from coalib.results.result_actions.IgnoreResultAction import IgnoreResultAction
-from coalib.results.result_actions.OpenEditorAction import OpenEditorAction
-from coalib.results.result_actions.PrintAspectAction import PrintAspectAction
 from coalib.results.result_actions.PrintMoreInfoAction import  \
     PrintMoreInfoAction
 from coalib.results.result_actions.PrintDebugMessageAction import \

@gitmate-bot
Copy link
Collaborator

Comment on 6aa5a18, file coalib/coala_main.py, line 11.

This file contains unused source code.

Origin: PyUnusedCodeBear, Section: flakes.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpqh7k6trq/coalib/coala_main.py
+++ b/tmp/tmpqh7k6trq/coalib/coala_main.py
@@ -8,12 +8,6 @@
 from coalib.output.Logging import CounterHandler
 from coalib.processes.Processing import execute_section, simplify_section_result
 from coalib.settings.ConfigurationGathering import gather_configuration
-from coalib.results.result_actions.DoNothingAction import DoNothingAction
-from coalib.results.result_actions.ShowPatchAction import ShowPatchAction
-from coalib.results.result_actions.ApplyPatchAction import ApplyPatchAction
-from coalib.results.result_actions.IgnoreResultAction import IgnoreResultAction
-from coalib.results.result_actions.OpenEditorAction import OpenEditorAction
-from coalib.results.result_actions.PrintAspectAction import PrintAspectAction
 from coalib.results.result_actions.PrintMoreInfoAction import  \
     PrintMoreInfoAction
 from coalib.results.result_actions.PrintDebugMessageAction import \

@gitmate-bot
Copy link
Collaborator

Comment on 5c3c3ff, file coalib/coala_main.py, line 11.

This file contains unused source code.

Origin: PyUnusedCodeBear, Section: flakes.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpe6lck5xy/coalib/coala_main.py
+++ b/tmp/tmpe6lck5xy/coalib/coala_main.py
@@ -8,12 +8,6 @@
 from coalib.output.Logging import CounterHandler
 from coalib.processes.Processing import execute_section, simplify_section_result
 from coalib.settings.ConfigurationGathering import gather_configuration
-from coalib.results.result_actions.DoNothingAction import DoNothingAction
-from coalib.results.result_actions.ShowPatchAction import ShowPatchAction
-from coalib.results.result_actions.ApplyPatchAction import ApplyPatchAction
-from coalib.results.result_actions.IgnoreResultAction import IgnoreResultAction
-from coalib.results.result_actions.OpenEditorAction import OpenEditorAction
-from coalib.results.result_actions.PrintAspectAction import PrintAspectAction
 from coalib.results.result_actions.PrintMoreInfoAction import  \
     PrintMoreInfoAction
 from coalib.results.result_actions.PrintDebugMessageAction import \

This allows selection of the actions when the -A
tag is used.The actions can now be selected with
the appropriate number or character.

Fixes: coala#5166
Copy link
Contributor

@saksham189 saksham189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to add tests for ConsoleInteraction.py and one test for coalaCITest.py has failed.
Check CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

coala running with -A tag not providing any options to select from
4 participants