linter: Add new parameters to normalize numbers #5350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jayvdb
requested changes
Apr 20, 2018
| @@ -43,6 +44,15 @@ def _prepare_options(options, bear_class): | |||
| if not options['use_stdout'] and not options['use_stderr']: | |||
| raise ValueError('No output streams provided at all.') | |||
|
|
|||
| if options['convert_index']: | |||
There was a problem hiding this comment.
dont abuse strings like this.
there are four possible scenarios, being the combinations of.
- increment line numbers, or dont touch them.
- increment column numbers, or dont touch them.
those should be two meaningful arg names, bool obviously.
arg names are checked by the Python runtime, providing consistent error messages. the user documentation becomes easy. etc. etc.
Add new parameters `normalize_line_numbers` and `normalize_column_numbers` to handle the conversion from zero-based to one-based conventions. Closes coala#5346
li-boxuan
force-pushed
the
linter_convert_index
branch
from
04a3dfe
to
229bd95
Compare
jayvdb
changed the title
convert_index
jayvdb
approved these changes
Apr 22, 2018
|
ack 229bd95 |
gitmate-bot
added
process/approved
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
gitmate-bot
removed
the
process/approved
gitmate-bot
added
the
process/approved
gitmate-bot
removed
the
process/approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Control line-index and column-index conversion
to handle zero-based and one-based conventions.
Closes #5346
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!