docs/index.rst: Replace PNG coala header with SVG #5832
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitmate-bot
reviewed
Oct 19, 2018
gitmate-bot
reviewed
Oct 19, 2018
sangamcse
force-pushed
the
issues#5592
branch
from
c87ce92
to
661b9bb
Compare
gitmate-bot
reviewed
Oct 19, 2018
gitmate-bot
reviewed
Oct 19, 2018
docs/_static/custom.css
Outdated
| @@ -147,6 +147,11 @@ img { | |||
| max-width: 100%; | |||
| } | |||
|
|
|||
| img.header { | |||
There was a problem hiding this comment.
Element (img.header) is overqualified, just use .header without element name. (overqualified-elements)
Origin: CSSLintBear, Section: css.
sangamcse
force-pushed
the
issues#5592
branch
from
661b9bb
to
933ff6a
Compare
The SVG of coala-header has been merged into coala/artwork so this removes the PNG header and replace it with the SVG and CSS. Also, the `30em` width makes it responsive according to the window size. Closes coala#5592
sangamcse
force-pushed
the
issues#5592
branch
from
933ff6a
to
d847341
Compare
jayvdb
added
the
status/blocked
|
@sangamcse , this needs to be done in the moban template repo. ping @ayan-b to help you. The .svg needs to be sync'd to the template repo, and then the template repo's .css needs to be updated and propogated to both the documentation and coala repos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SVG of coala-header has been merged into coala/artwork
so this removes the PNG header and replace it with the SVG
and CSS. Also, the
30emwidth makes it responsive accordingto the window size.
Closes #5592
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!