Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File issue does not work for GitHub Pages repositories #252

Closed
co-robo opened this issue Aug 9, 2017 · 1 comment
Closed

File issue does not work for GitHub Pages repositories #252

co-robo opened this issue Aug 9, 2017 · 1 comment
Assignees
@andrewda
Labels
difficulty/low importance/medium initiatives/gci type/regex

Comments

@co-robo
Copy link

co-robo commented Aug 9, 2017

It looks like the regex for LabHub issue filer doesn't work for GitHub pages repositories.

examples of repo names:
@jayvdb
Copy link
Member

jayvdb commented Nov 27, 2017

This requires writing tests, and that tests are not newcomer level in corobo due to its current state.

@jayvdb jayvdb changed the title file issue won't work for GitHub page repositories File issue does not work for GitHub Pages repositories Nov 27, 2017
andrewda added a commit to andrewda/corobo that referenced this issue Nov 28, 2017
@andrewda
labhub.py: Allow periods in repository names
bf693ab 
This allows repository names to contain periods when creating
issues, allowing for GitHub pages repos to be used.

Fixes coala#252
andrewda added a commit to andrewda/corobo that referenced this issue Nov 28, 2017
@andrewda
labhub.py: Allow periods in repository names
589c6e3 
This allows repository names to contain periods when creating
issues, allowing for GitHub pages repos to be used.

Fixes coala#252
@andrewda andrewda mentioned this issue Nov 28, 2017
Merged
6 tasks
yashasingh pushed a commit to yashasingh/corobo that referenced this issue Nov 29, 2017
@andrewda @yashasingh
labhub.py: Allow periods in repository names
7ceddd8 
This allows repository names to contain periods when creating
issues, allowing for GitHub pages repos to be used.

Fixes coala#252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrewda andrewda

Labels
difficulty/low importance/medium initiatives/gci type/regex
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jayvdb @meetmangukiya @andrewda @gitmate-bot @co-robo