On Zulip, ROOMS_TO_JOIN should contain valid Zulip rooms #635
Comments
|
This is GCI task https://codein.withgoogle.com/dashboard/tasks/6377821476749312/ |
|
@jayvdb does the bot need to scrape zulip, use the zulip api, or is this just a static list of rooms pertinent to the bot? |
Nevermind. I see what you mean(I think) I'll update the list. :-) |
|
It can be a static list. |
This was referenced Oct 24, 2018
Closed
why-does-ie-still-exist
added a commit
to why-does-ie-still-exist/corobo
that referenced
this issue
Oct 26, 2018
Added this code which if the `BACKEND` is run as `'Zulip'` `ROOMS_TO_JOIN` is updated accordingly. I noticed there's not much code for Zulip(a cursory search shows no matches in the repo). So this will probably make someone's life easier down the line when they port the bot. closes coala#635 Update config.py
why-does-ie-still-exist
added a commit
to why-does-ie-still-exist/corobo
that referenced
this issue
Oct 26, 2018
Added this code which if the `BACKEND` is run as `'Zulip'` `ROOMS_TO_JOIN` is updated accordingly. I noticed there's not much code for Zulip(a cursory search shows no matches in the repo). So this will probably make someone's life easier down the line when they port the bot. closes coala#635
why-does-ie-still-exist
added a commit
to why-does-ie-still-exist/corobo
that referenced
this issue
Oct 26, 2018
Added this code which if the `BACKEND` is run as `'Zulip'` `ROOMS_TO_JOIN` is updated accordingly. I noticed there's not much code for Zulip(a cursory search shows no matches in the repo). So this will probably make someone's life easier down the line when they port the bot. closes coala#635
why-does-ie-still-exist
added a commit
to why-does-ie-still-exist/corobo
that referenced
this issue
Oct 26, 2018
Added this code which if the `BACKEND` is run as `'Zulip'` `ROOMS_TO_JOIN` is updated accordingly. I noticed there's not much code for Zulip(a cursory search shows no matches in the repo). So this will probably make someone's life easier down the line when they port the bot. closes coala#635
6 tasks
jayvdb
pushed a commit
to why-does-ie-still-exist/corobo
that referenced
this issue
Oct 26, 2018
Added this code which if the `BACKEND` is run as `'Zulip'` `ROOMS_TO_JOIN` is updated accordingly. Closes coala#635
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Following on from #634 , the rooms list needs to be updated on backend Zulip to contain only rooms which exist on the coala Zulip server , otherwise there are lots of errors on startup.
Note that 'maintainers' (same as gitter coala/coala/maintainers) and 'gci-mentors-2018' (no gitter equivalent) are two private rooms the bot also needs to join on Zulip.
The text was updated successfully, but these errors were encountered: