Setup jest #130

li-boxuan · 2018-07-28T15:36:42Z

TravisBuddy · 2018-07-29T04:27:56Z

Travis tests have failed

Hey @li-boxuan,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

Node.js: undefined

npm run test

> gh-board@0.0.0 test /home/travis/build/coala/gh-board
> ./script/run-test.sh

+files=("issues.json" "recent-issues.json")
+for file in '"${files[@]}"'
+[[ -f issues.json ]]
+echo 'File issues.json exists.'
File issues.json exists.
+for file in '"${files[@]}"'
+[[ -f recent-issues.json ]]
+echo 'File recent-issues.json exists.'
File recent-issues.json exists.
++npm bin
+/home/travis/build/coala/gh-board/node_modules/.bin/jest
/home/travis/build/coala/gh-board/jest.config.js:30
  coverageDirectory: "coverage",
  ^^^^^^^^^^^^^^^^^

SyntaxError: Unexpected identifier
    at createScript (vm.js:80:10)
    at Object.runInThisContext (vm.js:139:10)
    at Module._compile (module.js:599:28)
    at Object.Module._extensions..js (module.js:646:10)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)
    at Module.require (module.js:579:17)
    at require (internal/module.js:11:18)
    at exports.default.configPath (/home/travis/build/coala/gh-board/node_modules/jest-config/build/read_config_file_and_set_root_dir.js:44:20)
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! gh-board@0.0.0 test: `./script/run-test.sh`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the gh-board@0.0.0 test script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2018-07-29T04_27_38_705Z-debug.log

blazeu · 2018-07-29T05:25:51Z

package.json

@@ -37,18 +37,22 @@
    "babel-plugin-transform-class-properties": "^6.24.1",
    "babel-plugin-transform-object-rest-spread": "^6.26.0",
    "babel-preset-env": "^1.6.1",
+    "babel-preset-es2015": "^6.24.1",


env should cover for es2015 already

http://babeljs.io/docs/en/env/

blazeu · 2018-07-29T05:26:58Z

.babelrc

@@ -0,0 +1,3 @@
+{
+  "presets": ["es2015", "react"]


Extract this fom webpack conf

gh-board/webpack.config.js

Lines 29 to 38 in 3c8b0e5

options: {

presets: [

'react',

'env'

],

plugins: [

'react-require',

'transform-object-rest-spread',

'transform-class-properties'

],

babel-loader will also read from .babelrc if it exists.

blazeu · 2018-07-29T12:11:22Z

src/components/reactions.jsx

@@ -1,3 +1,4 @@
+import React from 'react';


We don't need this now since we have the same config as webpack?

jayvdb · 2018-07-29T12:40:01Z

Some general thoughts:

I believe .babelrc stuff can be put into package.json .. I prefer that, but what about other ppl?

codecov.yml is currently doing nothing, so isnt necessary. Data can be sent to codecov without it, and the percentage will slowly rise. until it gets to a decent percentage, tracking that isnt useful.

travis after_success/after_failure needs to be deactivated for the moban job.

jest.config.js - I am not a fan of checking in a large config file of comments about possible settings. We know whether to find the docs if we want more settings.

jayvdb

see comment above

wisn

Well, after all those reviews above this looks good to me.

wisn · 2018-07-29T17:15:56Z

@jayvdb I would prefer .babelrc than package.json

jayvdb · 2018-07-30T00:51:18Z

@wisn, why?

wisn · 2018-07-30T03:15:07Z

@jayvdb I knew that several peoples hate "tiny" file like .babelrc just for storing some configurations. If that's the case then we could merge Babel configuration to package.json. My reason to use .babelrc is to explicitly say that "this application using Babel and here is the configuration". Besides, package.json contains a lot of dependencies record already and I see it as a mess. Actually, based on this repo behavior and Babel lookup behavior, move Babel configuration to package.json would be good. Hence, we just need to make a deal since either way is literally the same.

How about you guys? @li-boxuan @andrewda @blazeu

nkprince007 · 2018-07-30T05:54:08Z

.babelrc

@@ -0,0 +1,11 @@
+{


This change is welcoming. Most of the text editors these days automatically pick up babelrc files and provide autocompletion features based on babel configuration.

nkprince007 · 2018-07-30T05:54:40Z

.codecov.yml

@@ -0,0 +1,9 @@
+comment: false


Like @jayvdb mentioned, we don't need a configuration to publish code coverage to codecov.

jayvdb · 2018-08-01T00:55:44Z

.travis.yml

@@ -18,18 +20,33 @@ jobs:
      before_script: false
      script: .ci/check_moban.sh
      after_success: false
+      after_failure: false


please add a disable_global variable like https://github.com/coala/git-task-list/blob/master/.travis.yml#L13 , so all extra jobs can re-use it.

jayvdb · 2018-08-01T01:28:03Z

.travis.yml

@@ -8,6 +8,8 @@ cache:
 # env forces jobs to be created from the top level settings
 env:
 jobs:
+  allow_failures:
+    - script: script/run-integration-test.sh


I am very surprised this works.
Please use a variable like we do in coala/coala repo for the job which is allowed to fail

Closes coala#129

Related to coala#129

Closes coala#45

jayvdb · 2018-08-03T01:24:38Z

a SyntaxError with the integration test

Move integration test into individual stage and allow failure for it. Related to coala#45

jayvdb · 2018-08-03T01:58:02Z

ack 59e9cba 8a3c49b 1f88cfa 3638063

jayvdb · 2018-08-03T01:58:17Z

@gitmate-bot ff

gitmate-bot · 2018-08-03T01:58:19Z

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

gitmate-bot · 2018-08-03T01:59:19Z

Automated fastforward with GitMate.io was successful! 🎉

gitmate-bot added process/pending review size/XXL difficulty/low importance/medium labels Jul 28, 2018

li-boxuan force-pushed the setup_jest branch from 2fbfca7 to 18ebe84 Compare July 29, 2018 04:06

blazeu requested changes Jul 29, 2018

View reviewed changes

li-boxuan force-pushed the setup_jest branch from 18ebe84 to d2af794 Compare July 29, 2018 06:14

blazeu requested changes Jul 29, 2018

View reviewed changes

blazeu requested review from wisn, andrewda and jayvdb July 29, 2018 12:12

li-boxuan force-pushed the setup_jest branch 2 times, most recently from 85fac2a to d609707 Compare July 29, 2018 12:38

jayvdb requested changes Jul 29, 2018

View reviewed changes

wisn approved these changes Jul 29, 2018

View reviewed changes

jayvdb requested a review from nkprince007 July 30, 2018 04:50

nkprince007 reviewed Jul 30, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Jul 30, 2018

li-boxuan force-pushed the setup_jest branch from d609707 to 4190c91 Compare July 30, 2018 14:20

gitmate-bot added process/pending review and removed process/wip labels Jul 30, 2018

li-boxuan force-pushed the setup_jest branch from 4190c91 to af1bff5 Compare July 30, 2018 14:22

jayvdb requested changes Aug 1, 2018

View reviewed changes

jayvdb added the process/wip label Aug 1, 2018

jayvdb removed the process/pending review label Aug 1, 2018

li-boxuan force-pushed the setup_jest branch from af1bff5 to cde3162 Compare August 1, 2018 15:01

gitmate-bot added process/pending review and removed process/wip labels Aug 1, 2018

li-boxuan added 3 commits August 3, 2018 08:51

Setup Jest configurations

59e9cba

Closes coala#129

reactions.jsx: Add snapshot test

8a3c49b

Related to coala#129

Add codecov

1f88cfa

Closes coala#45

li-boxuan force-pushed the setup_jest branch from cde3162 to b33d132 Compare August 3, 2018 00:53

jayvdb approved these changes Aug 3, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Aug 3, 2018

li-boxuan force-pushed the setup_jest branch from b33d132 to 4e445f4 Compare August 3, 2018 01:29

gitmate-bot added process/pending review and removed process/wip labels Aug 3, 2018

Separate test logic

3638063

Move integration test into individual stage and allow failure for it. Related to coala#45

li-boxuan force-pushed the setup_jest branch from 4e445f4 to 3638063 Compare August 3, 2018 01:42

gitmate-bot added process/approved and removed process/pending review labels Aug 3, 2018

gitmate-bot merged commit 3638063 into coala:master Aug 3, 2018

gitmate-bot removed the process/approved label Aug 3, 2018

gitmate-bot added the process/approved label Aug 3, 2018

li-boxuan deleted the setup_jest branch August 3, 2018 14:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setup jest #130

Setup jest #130

li-boxuan commented Jul 28, 2018

TravisBuddy commented Jul 29, 2018

blazeu Jul 29, 2018

blazeu Jul 29, 2018

blazeu Jul 29, 2018

jayvdb commented Jul 29, 2018

jayvdb left a comment

wisn left a comment

wisn commented Jul 29, 2018

jayvdb commented Jul 30, 2018

wisn commented Jul 30, 2018

nkprince007 Jul 30, 2018

nkprince007 Jul 30, 2018

jayvdb Aug 1, 2018

jayvdb Aug 1, 2018

jayvdb commented Aug 3, 2018

jayvdb commented Aug 3, 2018

jayvdb commented Aug 3, 2018

gitmate-bot commented Aug 3, 2018

gitmate-bot commented Aug 3, 2018

	options: {
	presets: [
	'react',
	'env'
	],
	plugins: [
	'react-require',
	'transform-object-rest-spread',
	'transform-class-properties'
	],

Setup jest #130

Setup jest #130

Conversation

li-boxuan commented Jul 28, 2018

TravisBuddy commented Jul 29, 2018

Travis tests have failed

Node.js: undefined

blazeu Jul 29, 2018

Choose a reason for hiding this comment

blazeu Jul 29, 2018

Choose a reason for hiding this comment

blazeu Jul 29, 2018

Choose a reason for hiding this comment

jayvdb commented Jul 29, 2018

jayvdb left a comment

Choose a reason for hiding this comment

wisn left a comment

Choose a reason for hiding this comment

wisn commented Jul 29, 2018

jayvdb commented Jul 30, 2018

wisn commented Jul 30, 2018

nkprince007 Jul 30, 2018

Choose a reason for hiding this comment

nkprince007 Jul 30, 2018

Choose a reason for hiding this comment

jayvdb Aug 1, 2018

Choose a reason for hiding this comment

jayvdb Aug 1, 2018

Choose a reason for hiding this comment

jayvdb commented Aug 3, 2018

jayvdb commented Aug 3, 2018

jayvdb commented Aug 3, 2018

gitmate-bot commented Aug 3, 2018

gitmate-bot commented Aug 3, 2018