-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
coalaOnline: Add support for optional settings #206
Conversation
@@ -117,31 +117,47 @@ | |||
<div btf-markdown="currentBear.metadata.desc" class="description"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
Origin: SpaceConsistencyBear, Section: spacing
.
The issue can be fixed by applying the following patch:
--- a/partials/tabs/languages.html
+++ b/partials/tabs/languages.html
@@ -122,7 +122,7 @@
<div class="small-heading">SETTINGS</div>
<br>
-
+
<div class="settings">
<span class="settings-options">
<i class="fa fa-square light-blue-text text-accent-3" aria-hidden="true"></i>
@@ -117,31 +117,47 @@ | |||
<div btf-markdown="currentBear.metadata.desc" class="description"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing Whitespace: Trailing white spaces are unnecessary and can complicate diffs: Remove the ' ' at the end of the line.
Origin: HTMLLintBear, Section: html
.
right align the setting names please |
87be301
to
052539a
Compare
resources/js/app.js
Outdated
} | ||
if (match_by_lang == 1) { | ||
for (var x = 0; x < bears.length; x++) { | ||
var found = returnArray.some(function (el) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems overly complicated, why don't you just return all bears that have the language listed plus all that have the all listed and just ignore the returnArray?
@rultor merge |
@hemangsk @sils Oops, I failed. You can see the full log here (spent 2min)
|
@gitmate-bot rebase |
Hey! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost! |
@gitmate-bot would you mind? A rebase please. |
Hey! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost! |
@gitmate-bot would you mind? A rebase please. |
Hey! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost! |
6d09ae9
to
a48a08a
Compare
Automated rebase was successful! |
@rultor merge |
1 similar comment
@rultor merge |
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>
to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!