Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitmate plugins #488

Closed
jayvdb opened this issue Mar 19, 2018 · 11 comments
Closed

gitmate plugins #488

jayvdb opened this issue Mar 19, 2018 · 11 comments
Assignees

Comments

@jayvdb
Copy link
Member

jayvdb commented Mar 19, 2018

coala uses http://gitmate.io to automate our systems.

While it works very well, there are a number of plugins which need extra complexity to better suit coala, and there are new plugin ideas we have all the time, but never get around to building. As these are coala-centric enhancements, they often fall off the gitmate priority list. The extensible framework is there; we need to utilise it better.

@jayvdb
Copy link
Member Author

jayvdb commented Mar 19, 2018

We have rebase and ff plugins, but a lot of maintainer time can be saved by integrating both of those into an auto-merger.

GitLab has a 'merge when pipelines pass' feature, which GitHub doesnt have.
It would be possible to build GitHub support into the IGitt layer, and needs to be combined with a mechanism for checking it succeeded or failed.

However that is still only operating on a single MR. Ideally maintainers can approve a few MRs/PRs, and gitmate looks after the details of getting them rebased & merged if there are no conflicts.

@jayvdb
Copy link
Member Author

jayvdb commented Mar 19, 2018

Pull Requests from master should be automatically rejected, with instructions on how to fix their branch, fix their master, and resubmit a PR.

(This is a nice easy one, as IGitt already has the metadata needed, and could be done during community bonding, or first coding phase)

@jayvdb
Copy link
Member Author

jayvdb commented Mar 19, 2018

coala/coala#5155 - Fixes vs Closes automated checking

IGitt has the relevant information : see https://gitlab.com/gitmate/open-source/IGitt/merge_requests/98

@jayvdb
Copy link
Member Author

jayvdb commented Mar 19, 2018

Note that #489 is a separate project covering enhancements to GitCommitBear especially.

@jayvdb
Copy link
Member Author

jayvdb commented Mar 19, 2018

Another plugin requested is automatically marking WIP if gitmate's coala plugin finds defects.

@jayvdb
Copy link
Member Author

jayvdb commented Mar 19, 2018

A squash command would be useful, to automagically fix a PR with lots of messy commits, so we can merge it - helpful to newcomers only , instead of them creating a new PR.

Actually it would be interesting to see how rebase handles a GitHub rebase from master...

Maybe call it something like 'unbork' , so there is a bit of a negative connotation to it, so it isnt used instead of following normal development best practises.

However, there was a suggestion that we move to a GitHub flow , where incremental improvements are added as extra commits until the PR is ready to land, to easy code review, in which case a squash at the end would prepare the PR for landing.

@rohanrk
Copy link
Member

rohanrk commented Mar 19, 2018

I'm be interested in this. You said that the documentation is stored in the webapp? How do newcomers access those docs?

Also automatically mark PRs that fail CI as WIP would be a good plugin.

@jayvdb
Copy link
Member Author

jayvdb commented Mar 19, 2018

You'll need to ask the gitmate devs, almost all of which are also coala developers. Their source is at https://gitlab.com/gitmate/open-source

@Makman2
Copy link
Member

Makman2 commented Mar 19, 2018

I would like to see advanced configuration management, what I currently have in mind is to manage a set of configurations that can be applied quickly to multiple projects at once or are automatically synced if a repo uses that configuration.
Changing a single setting inside a repo in an organization and making it reflect in all other repos is a pain for 5+ repos.

EDIT:
I would like to see -> I think it would be a useful feature for this gsoc project

@jayvdb
Copy link
Member Author

jayvdb commented Mar 23, 2018

@Makman2 , @nkprince007 , see #487 for configuration of gitmate from YAML inside a repo (and we would do the syncing between repos in another tool; likely moban)

@jayvdb
Copy link
Member Author

jayvdb commented Aug 2, 2018

The project page should have been updated during bonding, but too late for that I guess. See cEP for final project concepts.

@jayvdb jayvdb closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants