Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more Content-Formats #282

Merged
merged 5 commits into from
Sep 28, 2021
Merged

feat: add more Content-Formats #282

merged 5 commits into from
Sep 28, 2021

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Sep 28, 2021

This PR adds a number of missing Content-Formats as a default and makes it possible to use Content-Formats with parameters. It also updates the README with a table of the supported Content-Formats instead of a JavaScript source code listing.

There might be an issue that arises from the fact that the space between Media-Type and parameters is optional but I would deal with that in another PR.

@coveralls
Copy link

coveralls commented Sep 28, 2021

Pull Request Test Coverage Report for Build 1282300270

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 89.697%

Totals Coverage Status
Change from base Build 1280604248: -0.1%
Covered Lines: 1067
Relevant Lines: 1158

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1282257649

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 89.581%

Files with Coverage Reduction New Missed Lines %
lib/cache.js 2 94.74%
Totals Coverage Status
Change from base Build 1280604248: -0.2%
Covered Lines: 1065
Relevant Lines: 1158

💛 - Coveralls

@JKRhb JKRhb merged commit 3a8b045 into coapjs:master Sep 28, 2021
@JKRhb JKRhb deleted the content-formats branch September 28, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants