feat: let OutgoingMessage implement BufferList interface
#326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1735858740
💛 - Coveralls |
JKRhb
changed the title
OutgoingMessage explicitly implement Duplex interfaceOutgoingMessage implement BufferList interface
|
I just noticed that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR lets the
OutgoingMessagetransitively implement theDuplexinterface from thereadable-streammodule by adding an implementation of theBufferListinterface. This fixes compatibility issues with Node.js stream functions (and incorporates a recent update of the respective types module).This PR is related to this issue in the node-wot repository.
The PR does not change any functionality, therefore the CI should stay green.