Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix IPv6 related multicast problem #339

Merged
merged 4 commits into from
Apr 23, 2022

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Apr 23, 2022

I noticed that there is a problem with IPv6 multicast addresses in the server right now. This PR adds a test case to illustrate the problem and a workaround to fix it, as iterating over all IPv6 interfaces does not work as it does in the IPv4 case.

The new test is skipped in the case of Mac OS as there seem to be problems related to IPv6 multicast (addMembership EADDRNOTAVAIL).

@coveralls
Copy link

coveralls commented Apr 23, 2022

Pull Request Test Coverage Report for Build 2213445822

  • 36 of 40 (90.0%) changed or added relevant lines in 2 files are covered.
  • 97 unchanged lines in 11 files lost coverage.
  • Overall coverage increased (+7.3%) to 94.533%

Changes Missing Coverage Covered Lines Changed/Added Lines %
test/server.ts 31 35 88.57%
Files with Coverage Reduction New Missed Lines %
lib/outgoing_message.ts 1 97.92%
index.ts 2 93.43%
lib/helpers.ts 2 97.07%
lib/observe_read_stream.ts 2 92.21%
lib/observe_write_stream.ts 2 95.1%
lib/cache.ts 3 92.0%
lib/segmentation.ts 3 89.58%
lib/option_converter.ts 4 94.39%
lib/middlewares.ts 5 87.4%
lib/agent.ts 28 87.27%
Totals Coverage Status
Change from base Build 2201295132: 7.3%
Covered Lines: 8681
Relevant Lines: 9085

💛 - Coveralls

@JKRhb JKRhb force-pushed the ipv6-multicast-test branch 2 times, most recently from b30e581 to fca4ba8 Compare April 23, 2022 18:08
@JKRhb JKRhb marked this pull request as ready for review April 23, 2022 18:09
@Apollon77 Apollon77 merged commit 92fc20d into coapjs:master Apr 23, 2022
@JKRhb JKRhb deleted the ipv6-multicast-test branch April 23, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants