Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix observe when receiving block2 response #343

Merged
merged 2 commits into from
May 11, 2022

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Apr 23, 2022

This PR incorporates the suggested change by @Thousif-khan and should fix #336.

@coveralls
Copy link

coveralls commented Apr 23, 2022

Pull Request Test Coverage Report for Build 2251396779

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 91.399%

Totals Coverage Status
Change from base Build 2216214651: -0.4%
Covered Lines: 2821
Relevant Lines: 3033

💛 - Coveralls

@JKRhb
Copy link
Member Author

JKRhb commented Apr 24, 2022

I think we should probably merge #344 first (which addresses some more fundamental observe issues) and see afterwards if this PR is still needed.

@Apollon77
Copy link
Collaborator

Ok, I release a 1.0.8 with #34 in and then we test again

@JKRhb
Copy link
Member Author

JKRhb commented Apr 24, 2022

Ok, I release a 1.0.8 with #34 in and then we test again

Awesome, thank you :)

@JKRhb
Copy link
Member Author

JKRhb commented Apr 24, 2022

Hmm. Not sure if the additional if check changed anything?

@Apollon77
Copy link
Collaborator

Will merge and release tonight. Sorry for the delay

@Apollon77 Apollon77 merged commit 412a400 into coapjs:master May 11, 2022
@JKRhb JKRhb deleted the observe-blockwise-fix branch May 11, 2022 18:18
JKRhb added a commit to JKRhb/node-coap that referenced this pull request May 17, 2022
* fix: fix observe when receiving block2 response

* chore: bump version to 1.0.9
JKRhb added a commit to JKRhb/node-coap that referenced this pull request May 17, 2022
* fix: fix observe when receiving block2 response

* chore: bump version to 1.0.9
JKRhb added a commit to JKRhb/node-coap that referenced this pull request May 17, 2022
* fix: fix observe when receiving block2 response

* chore: bump version to 1.0.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reset msg on separated response(observe) with block2 option
3 participants