Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expression signing and verification migrated to Rust #452

Merged
merged 31 commits into from
Feb 28, 2024
Merged

Expression signing and verification migrated to Rust #452

merged 31 commits into from
Feb 28, 2024

Conversation

lucksus
Copy link
Member

@lucksus lucksus commented Feb 20, 2024 •
edited

Next to a SIGNATURES JS extension, this also adds an AGENT extension and moves over another large portion of the AgentService from JS to Rust.

@lucksus
Add signatures.rs
f3fbbc9
@lucksus
Remove verify from WALLET extension
3861025
@lucksus
WIP signature extension
9b9d6df
@lucksus
Fix signatures return/error types
6ee9d6c
@lucksus
create_signed_expression() and did functions in Rust
e829b3a
@lucksus
agent JS extension
a72189d
@lucksus
Replace all JS Signature code with Rust ext calls + use AGENT ext. in…
1cb7e2c 
… some places
@lucksus
Register new extensions
1ceb0da
@lucksus
Signature/verify roundtrip tests
255ed31
@lucksus
Fix return values of SIGNATURE.verify
e891d6b
@lucksus
Merge branch 'dev' into rust-signatures
0c5c623 
# Conflicts:
#	executor/src/core/LanguageController.ts
#	executor/src/core/agent/Signatures.ts
@lucksus
Move tagExpressionSignatureStatus to utils
0b46f9e
@lucksus
Ensure all link expressions have signature valid tags
3fc461b
@lucksus
Adjust assertion to include sig tags
98351ff
@lucksus
For removing links from DB, don’t expect LinkExpression to be exactly…
c8e7c2e 
… the same

so that virtual properties like “valid”/“invalid” don’t make the linkexpression be considered different
@lucksus
Fix breaking debug log when zome call payload can’t be converted to s…
d3ac986 
…tring
@lucksus
Add tests that ensures signature verification can handle changed sort…
4901fc8 
…ing in json value
@lucksus
Make sure signature verify can handle different sortings
0a0358b
@lucksus
Add signature test for string data
39c8adb
@lucksus
Use Zulu format for timestamps
8e2e525
@lucksus
Decouple signature verification from timestamp format
044c7b7
@lucksus
Fix signature tags in perspective link subscriptions
20f54f2
@lucksus
Add signature tags for links incoming from link language
485db3a
@lucksus
Merge branch 'dev' into rust-signatures
a08ed46
@lucksus lucksus marked this pull request as ready for review February 26, 2024 16:30
@lucksus lucksus changed the title Rust signatures Expression signing and verification migrated to Rust Feb 26, 2024
@lucksus lucksus requested a review from fayeed February 26, 2024 16:33
@lucksus lucksus merged commit ca1f623 into dev Feb 28, 2024
2 checks passed
@lucksus lucksus mentioned this pull request Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fayeed fayeed fayeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucksus @fayeed