Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic serve command #68

Merged
merged 3 commits into from
Apr 1, 2016
Merged

Add basic serve command #68

merged 3 commits into from
Apr 1, 2016

Conversation

tak1n
Copy link
Member

@tak1n tak1n commented Mar 30, 2016

Unfortunately I'm not that confident in rust yet so no tests for that.

Also do we need a test for just a basic command like this?
We are just using nickel therefore nickel should have a good test suite and done :D

This closes #50

@johannhof
Copy link
Contributor

This should be in main.rs and not in cobalt.rs, as it's more a convenience functionality provided by our "frontend" and not part of the generator.

I'm good with no tests for this

@tak1n
Copy link
Member Author

tak1n commented Mar 31, 2016

Done

@johannhof
Copy link
Contributor

So we can make followup bugs for this, but there are two things that come to mind right now:

  • serve isn't very useful as it is without watch, we should implement that
  • the user should be able to specify the port to serve on

But yeah, let's make some followup issues for that

👍

@johannhof johannhof merged commit 95b91b0 into master Apr 1, 2016
@johannhof johannhof deleted the serve_command branch April 1, 2016 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a serve(r) command
2 participants