Temp Fix for watched folders and Added RSS author attribute. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
changed the title
| @@ -128,8 +128,10 @@ pub fn build(config: &Config) -> Result<()> { | |||
| !template_extensions.contains(&f.path() | |||
| .extension() | |||
| .unwrap_or(OsStr::new(""))) && | |||
| f.path() != dest && f.path() != layouts_path.as_path() | |||
| f.path() != dest && !f.path().starts_with(Path::new("./").join(dest)) && | |||
There was a problem hiding this comment.
Not sure if this is solving the problem cleanly enough. From what I can gather you want to prevent copying things that are inside the /dest folder. I think a better way to do this is to replace the filter above with filter_entry from walkdir (see http://burntsushi.net/rustdoc/walkdir/#example-skip-hidden-files-and-directories-efficiently-on-unix)
|
I'm a bit unsure about the way you check if the watched file is not in the dest directory. An alternative would be to walk over What do you think? :) |
|
@johannhof I'm thinking of using the stuff on #86 instead of the stuff in this PR. What do you think? |
|
Closing this so that it can be implemented properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small temp fixes for path issues when the build folder is in the same dir as the source folder.
Fixes #84 and Partly Fixes #63.