-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added upload command with ghp-rs #93
Conversation
Really nice! But the name |
@johannhof I agree. I am very open to any suggestions. |
Mmmmh maybe |
I've seen this being called |
@johannhof added some fixes. I went with |
@@ -28,9 +30,10 @@ fn print_version() { | |||
} | |||
|
|||
fn print_usage(opts: Options) { | |||
let usage = concat!("\n\tbuild -- build the cobalt project at the source dir", | |||
let usage = concat!("\n\tbuild -- build the cobalt project at the source dir, -i --import will import the site to the gh-pages branch", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why add the --import
instruction here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johannhof so you can run cobalt build -b src -d build --import
and it will build then import. It would be useful for ci tools to do it all in one command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I meant you already documented it below, I think documenting it in that line is unnecessary :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm I see what you are saying I will remove it then merge.
@LucioFranco looks great, I had one comment but good to merge otherwise! |
🎉 |
Last week I wrote a small gh-pages import library similar to ghp-import that was written in python. I have added a subcommand for
cobalt
. Let me know what you think @johannhof . I was also thinking it may be better to have itcobalt build --upload
rather thancobalt upload
.