-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow expressions in indexed variables #145
Labels
Comments
We'll need a new parser for this, see #138 |
Some of the API refactorings I'm working on for #95 might make this more attainable with the existing code base. |
This was referenced Oct 5, 2018
epage
added a commit
to epage/liquid-rust
that referenced
this issue
Oct 18, 2018
This is a subset of cobalt-org#145. Fixes cobalt-org#209
#214 implemented a subset of this, including taking care of the api-break. |
Goncalerta
added a commit
to Goncalerta/liquid-rust
that referenced
this issue
Nov 30, 2018
Replace the old regex-based parser with a pest-based one. Introduce line/column context in some (syntax) errors (see cobalt-org#232). closes cobalt-org#138 fixes cobalt-org#145 fixes cobalt-org#226 fixes cobalt-org#227 fixes cobalt-org#242 BREAKING CHANGES Behavior - Expressions no longer support tags (they weren't supposed to) - More strictness in tokens accepted (Tags will raise an error if given a surplus of arguments. This is to alert the user for possible mistakes) API - Changed signature for tags and blocks - `compiler::parse` takes a `&str` directly as an argument, instead of requiring the midstep of `tokenize`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#141 added support for indexing literals
arr[0]
orobj["name"]
.This left out indexing by expressions like
result_string: {{ test_a[0][somevar] }}
The text was updated successfully, but these errors were encountered: