Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow expressions in indexed variables #145

Closed
epage opened this issue Nov 8, 2017 · 3 comments
Closed

Allow expressions in indexed variables #145

epage opened this issue Nov 8, 2017 · 3 comments
Labels
enhancement Improve the expected std-compatibility Jekyll flavor of liquid

Comments

@epage
Copy link
Member

epage commented Nov 8, 2017

#141 added support for indexing literals arr[0] or obj["name"].

This left out indexing by expressions like result_string: {{ test_a[0][somevar] }}

@epage epage added the std-compatibility Jekyll flavor of liquid label Nov 8, 2017
@epage
Copy link
Member Author

epage commented Nov 8, 2017

We'll need a new parser for this, see #138

@epage epage added api-break enhancement Improve the expected labels Dec 16, 2017
@epage
Copy link
Member Author

epage commented Dec 16, 2017

Some of the API refactorings I'm working on for #95 might make this more attainable with the existing code base.

@epage
Copy link
Member Author

epage commented Oct 18, 2018

#214 implemented a subset of this, including taking care of the api-break.

This was referenced Nov 1, 2018
Goncalerta added a commit to Goncalerta/liquid-rust that referenced this issue Nov 30, 2018
Replace the old regex-based parser with a pest-based one.
Introduce line/column context in some (syntax) errors (see cobalt-org#232).

closes cobalt-org#138
fixes cobalt-org#145
fixes cobalt-org#226
fixes cobalt-org#227
fixes cobalt-org#242

BREAKING CHANGES
Behavior
- Expressions no longer support tags (they weren't supposed to)
- More strictness in tokens accepted (Tags will raise an error if given a surplus of arguments. This is to alert the user for possible mistakes)
API
- Changed signature for tags and blocks
- `compiler::parse` takes a `&str` directly as an argument, instead of requiring the midstep of `tokenize`
@epage epage closed this as completed in dcac742 Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve the expected std-compatibility Jekyll flavor of liquid
Projects
None yet
Development

No branches or pull requests

1 participant