New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor API #149
Merged
Merged
Refactor API #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an intermediate step. The two APIs are still intermixed but this should be enough to start making the amount of progress on cobalt-org#95 needed for some cobalt changes that are blocked on liquid.
This is currently a one-time API until filters are made copyable. BREAKING CHANGE: Original API exists under `liquid::syntax` and does not automatically add any filters, tags, or blocks.
While at it, I put in an optimization for Filters, ParseTags, and ParseBlocks to reduce heap allocations when using `fn`s. BREAKING CHANGE: `Filter` has changed from a `Fn` to a trait.
Like truthiness, indexing logic is now consolidated. This also made it easier to consolidate the IdentifierPath and Variable logic. This does cause some inconsistency with shopify/liquid that we'll need to consider. They allow undefined variable access. BREAKING CHANGES: - `{ non_existent }` will now error rather than nothing. This particularly impacts `{ non_existent | default "fallback" }`. - Improves consistency between non-indexed and indexed behavior - Increase error reporting - value has now moved from `syntax::Value` to `value::Value`.
`for` loops provided both a `forloop` and `for_loop` variable, only the former being shopify compatible. BREAKING CHANGE: Change `for_loop` to `forloop`.
The CI failed saying it couldn't find the file `\\\\C:\\\\projects\\\\liquid-rust\\\\tests/fixtures/input/example.txt` My best guess is that `.join` on Windows isn't splitting path components on `/`, so I'm doing it explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major step towards #95
This also saw a consolidation of how variables are processed between pure-dots (name.value) and indexing (name["value"]). Not complete and indexing isn't yet available everywhere, but it should be easier to make it so.
This consolidation included error reporting. Now non-existent variables will always cause an error rather than being treated as false / "".
The other major format-breaking change is I removed
for_loop
variable which is a duplicate offorloop
, the latter being shopify compliant.This also saw a huge performance change for rendering
Before:
After