Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new test cases #21

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Add new test cases #21

merged 1 commit into from
Dec 28, 2020

Conversation

cobaltine
Copy link
Owner

Breaking changes:

  • Rename: FINGERPRINT_HASH_FUNCTIONS -> JFPV1_HASH_FUNCTIONS
  • Rename: FINGERPRINT_VERSIONS -> JSON_FINGERPRINT_VERSIONS

Other changes:

  • Refactored path formatting/building to a separate function
  • Renamed some internal functions for clarity
  • Added missing docstrings

New test cases:

  • Tests for handling of primitive types (int, float, str, bool)
  • Tests for refactored path builder function

Breaking changes:
 - Rename: FINGERPRINT_HASH_FUNCTIONS -> JFPV1_HASH_FUNCTIONS
 - Rename: FINGERPRINT_VERSIONS -> JSON_FINGERPRINT_VERSIONS

Other changes:
 - Refactored path formatting/building to a separate function
 - Renamed some internal functions for clarity
 - Added missing docstrings

New test cases:
 - Tests for handling of primitive types (int, float, str, bool)
 - Tests for refactored path builder function
@cobaltine cobaltine merged commit 5f06228 into main Dec 28, 2020
@cobaltine cobaltine deleted the new-test-cases branch December 28, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant