Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor modules and tests #minor #23

Merged
merged 1 commit into from
Jan 1, 2021
Merged

Refactor modules and tests #minor #23

merged 1 commit into from
Jan 1, 2021

Conversation

cobaltine
Copy link
Owner

Module structure:

  • Detached jfpv1 logic into a separate _jfpv1 module
  • Detached basic validators into a separate _validators module

Tests:

  • Simplified test runner execution with test module loading via
    the parent init.py
  • Extended and clarified docstrings for several tests
  • Split existing and new tests into a per-module type structure
  • Added more detailed tests (positive-negative testing) for exceptions
  • Extended 'manual' jfpv1 testing, from raw flattened json output to
    actual fingerprint

CI:

  • Updated test runner execution

Module structure:
 - Detached jfpv1 logic into a separate _jfpv1 module
 - Detached basic validators into a separate _validators module

Tests:
 - Simplified test runner execution with test module loading via
 the parent __init__.py
 - Extended and clarified docstrings for several tests
 - Split existing and new tests into a per-module type structure
 - Added more detailed tests (positive-negative testing) for exceptions
 - Extended 'manual' jfpv1 testing, from raw flattened json output to
 actual fingerprint

CI:
 - Updated test runner execution
@cobaltine cobaltine merged commit 52236ea into main Jan 1, 2021
@cobaltine cobaltine deleted the test-refactoring branch January 1, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant