Add support for SHA384 and SHA512 #minor #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for remaining in-scope SHA-2 algorithms: - SHA384 - SHA512 Dropped the idea of including checksum algorithms (namely adler32) as user-selectable algorithms. The various benefits of secure hashes outweigh the marginal performance benefits of checksum algorithms with the internal data format of jfpv1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for remaining in-scope SHA-2 algorithms:
Dropped the idea of including checksum algorithms (namely adler32) as
user-selectable algorithms. The various benefits of secure hashes
outweigh the marginal performance benefits of checksum algorithms with
the internal data format of jfpv1.